From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 39BE5A045E
	for <public@inbox.dpdk.org>; Thu, 30 May 2019 10:02:28 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 3114C5680;
	Thu, 30 May 2019 10:02:27 +0200 (CEST)
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 0CFA44F91
 for <dev@dpdk.org>; Thu, 30 May 2019 10:02:24 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 30 May 2019 01:02:23 -0700
X-ExtLoop1: 1
Received: from itopinsk-mobl.ccr.corp.intel.com (HELO [10.252.14.83])
 ([10.252.14.83])
 by fmsmga006.fm.intel.com with ESMTP; 30 May 2019 01:02:20 -0700
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Konstantin Ananyev <konstantin.ananyev@intel.com>,
 David Hunt <david.hunt@intel.com>,
 Bruce Richardson <bruce.richardson@intel.com>,
 Byron Marohn <byron.marohn@intel.com>,
 Pablo de Lara Guarch <pablo.de.lara.guarch@intel.com>,
 Yipeng Wang <yipeng1.wang@intel.com>, Sameh Gobriel
 <sameh.gobriel@intel.com>, Vladimir Medvedkin
 <vladimir.medvedkin@intel.com>, Olivier Matz <olivier.matz@6wind.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>,
 Reshma Pattan <reshma.pattan@intel.com>, thomas@monjalon.net,
 david.marchand@redhat.com
References: <cover.1559147228.git.anatoly.burakov@intel.com>
 <6551141356fbab88a06c94e54348177939be60b5.1559147228.git.anatoly.burakov@intel.com>
 <20190529094049.3cdd7dcd@hermes.lan>
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Message-ID: <541e14e6-d876-e378-297f-e16dad3b982c@intel.com>
Date: Thu, 30 May 2019 09:02:19 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <20190529094049.3cdd7dcd@hermes.lan>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 25/25] eal: hide shared memory config
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 29-May-19 5:40 PM, Stephen Hemminger wrote:
> On Wed, 29 May 2019 17:31:11 +0100
> Anatoly Burakov <anatoly.burakov@intel.com> wrote:
> 
>> +static inline void
>> +rte_eal_mcfg_wait_complete(struct rte_mem_config *mcfg)
>> +{
>> +	/* wait until shared mem_config finish initialising */
>> +	while (mcfg->magic != RTE_MAGIC)
>> +		rte_pause();
>> +}
>>
> 
> Not fast path, why is this inline?

I kept existing function. Have no preference one way or the other, can 
change in V2.

> 
>> +#endif // EAL_MEMCFG_H
> 
> Avoid C++ style comments.
> 

Will fix.

-- 
Thanks,
Anatoly