From: Thomas Monjalon <thomas@monjalon.net>
To: "P, Venkata Suresh Kumar" <venkata.suresh.kumar.p@intel.com>,
"Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Khangar, Churchill" <churchill.khangar@intel.com>,
"Jangra, Yogesh" <yogesh.jangra@intel.com>
Subject: Re: [dpdk-dev] [PATCH] port: add file descriptor SWX port
Date: Tue, 23 Mar 2021 20:55:49 +0100 [thread overview]
Message-ID: <5428359.QSTuVHgDrv@thomas> (raw)
In-Reply-To: <DM6PR11MB2796B50854BB5737AD041F34EB649@DM6PR11MB2796.namprd11.prod.outlook.com>
23/03/2021 19:56, Dumitrescu, Cristian:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 23/03/2021 19:07, P, Venkata Suresh Kumar:
> > > Thanks a lot for reviewing the code and providing your comments.
> > >
> > > I have addressed below comments in V2 patch.
> >
> > OK thanks.
> >
> > What about the question about rte_trace?
> > Opinions?
>
> Hi Thomas,
>
> All rte_swx_port ports are currently following this pattern,
> so it makes sense to have this one do the same for now.
>
> I am not that familiar with the (relatively new) rte_trace mechanism, so I am not sure if it has any run-time performance (I am assuming that it doesn't). We will take the AR to take a look at rte_trace and come back with a patch to convert traces for all ports to rte_trace, most likely in the 21.05 time frame. Is this OK for you?
Yes, would be great.
In general we should avoid such #ifdef in DPDK code.
Maybe rte_trace can help, maybe rte_log levels would suffice.
Note there is RTE_LOG_DP_LEVEL for logging in datapath.
next prev parent reply other threads:[~2021-03-23 19:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 12:02 Venkata Suresh Kumar P
2021-03-23 16:22 ` Thomas Monjalon
2021-03-23 18:07 ` P, Venkata Suresh Kumar
2021-03-23 18:38 ` Thomas Monjalon
2021-03-23 18:56 ` Dumitrescu, Cristian
2021-03-23 19:55 ` Thomas Monjalon [this message]
2021-03-24 10:23 ` Dumitrescu, Cristian
2021-03-23 18:24 ` Stephen Hemminger
2021-03-23 18:25 ` Stephen Hemminger
2021-03-23 18:29 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5428359.QSTuVHgDrv@thomas \
--to=thomas@monjalon.net \
--cc=churchill.khangar@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=venkata.suresh.kumar.p@intel.com \
--cc=yogesh.jangra@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).