From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mukawa@igel.co.jp>
Received: from mail-pd0-f182.google.com (mail-pd0-f182.google.com
 [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id 3DAB3212
 for <dev@dpdk.org>; Wed,  1 Oct 2014 03:32:49 +0200 (CEST)
Received: by mail-pd0-f182.google.com with SMTP id y10so100355pdj.27
 for <dev@dpdk.org>; Tue, 30 Sep 2014 18:39:31 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
 :cc:subject:references:in-reply-to:content-type
 :content-transfer-encoding;
 bh=uwl4BB9vf6BG2IcSvoZ8CQd3qNvC1SSqSmDumorcH/w=;
 b=JYmbnJlsd9GEA5J1Dy9F5d4lmzMTr3fLMMT/zzXv+elECaFx9D/KtFutBpOInFvHL7
 36TYMj9IHz/7HjVVt/Nq8MoWnZhjNqIorjF+bZw4N3yX5Nf058yG+QTFQEv0p5K32cHr
 z/hG2W8lLgMgi1mh1gSv2T15OSTogeJwNoAdLlB6oCCHXSpNroUGv0iqAjp/FRiq7BUD
 hFTor/znwioCs0lj2fBBqV/FJksfZGGu9pfFjJLnPH/PhKMxm7TjKtNySrZE2V64qrxO
 Hx5XiL1exRMF0URnsxuAh9r6+MtHuDs0PSOs3QnzLs9gFAHa0xGKktqxWmAR9V1SyEtY
 aTlg==
X-Gm-Message-State: ALoCoQm2NFSlWQRpdxDlKmrYgq9JWNj7UiTgY7mUuz1jPa1VemuvXJTo2SdpgfY/sZQleS//TbgT
X-Received: by 10.68.196.226 with SMTP id ip2mr73438176pbc.120.1412127571061; 
 Tue, 30 Sep 2014 18:39:31 -0700 (PDT)
Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132])
 by mx.google.com with ESMTPSA id nk11sm16327796pdb.40.2014.09.30.18.39.29
 for <multiple recipients>
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Tue, 30 Sep 2014 18:39:30 -0700 (PDT)
Message-ID: <542B5B51.9010303@igel.co.jp>
Date: Wed, 01 Oct 2014 10:39:29 +0900
From: Tetsuya Mukawa <mukawa@igel.co.jp>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: Neil Horman <nhorman@tuxdriver.com>
References: <mukawa@igel.co.jp>
 <1412070970-5625-1-git-send-email-mukawa@igel.co.jp>
 <1412070970-5625-3-git-send-email-mukawa@igel.co.jp>
 <20140930112353.GA2193@hmsreliant.think-freely.org>
In-Reply-To: <20140930112353.GA2193@hmsreliant.think-freely.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, nakajima.yoshihiro@lab.ntt.co.jp,
 masutani.hitoshi@lab.ntt.co.jp
Subject: Re: [dpdk-dev] [PATCH 2/2] librte_pmd_null: Enable librte_pmd_null
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Oct 2014 01:32:49 -0000

(2014/09/30 20:23), Neil Horman wrote:
> On Tue, Sep 30, 2014 at 06:56:10PM +0900, mukawa@igel.co.jp wrote:
>> From: Tetsuya Mukawa <mukawa@igel.co.jp>
>>
>> Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>
>> ---
>>  mk/rte.app.mk | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
>> index 34dff2a..f059290 100644
>> --- a/mk/rte.app.mk
>> +++ b/mk/rte.app.mk
>> @@ -179,6 +179,10 @@ LDLIBS += -lrte_pmd_xenvirt
>>  LDLIBS += -lxenstore
>>  endif
>>  
>> +ifeq ($(CONFIG_RTE_LIBRTE_PMD_NULL),y)
>> +LDLIBS += -lrte_pmd_null
>> +endif
>> +
> You don't need to add this, as the pmd can be loaded dynamically via the dlopen
> call executed via the -d option on the test app command line.  The only pmds
> that need explicit linking are those that offer additional API calls to an
> appilcation.
Thanks, I will change above.

Regards,
Tetsuya


> Neil
>
>>  ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),n)
>>  # plugins (link only if static libraries)
>>  
>> -- 
>> 1.9.1
>>
>>