From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com [209.85.220.45]) by dpdk.org (Postfix) with ESMTP id D889D212 for ; Thu, 2 Oct 2014 03:37:07 +0200 (CEST) Received: by mail-pa0-f45.google.com with SMTP id rd3so1325391pab.18 for ; Wed, 01 Oct 2014 18:43:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=9ZvcqhhLo+rYS0jmeNJf3catLKKXAB264ESp8jzY+88=; b=R2er3mJ1N65HzwCTEz9EAvb8oBpQPqr9xmCGVYB76Wfqyi/tDdYAiJV6bLUnHOYLEc gr/uSf0xClktmAa8WAfp4cLtqqZIzo4KC5ixchbUYqF37B+IXYLEu4P0upHaqkauqn+5 NfkWL3haLbQFkLqjUoadeVkRRaP/y9YUpMFnX89bA6Tleww+Lq96Osd5Cab03x8sKpOn la5/tcZ9mBvNTITMSUEMwJyUzsIny3d60e/6gm7owHxm+FiL0Pt9DgVRb/p9kDHwcRTg u+h2opI/FEWCnLdsAVIwNF5Jp9CbteQmY2rNDe3xpO7186YhdoVpWYNZZDfi+Du9QZ5S Kv2w== X-Gm-Message-State: ALoCoQmUU9pe5EqQ0F2EYrmKYjp7gBU1co0nwGHR/ewfTF/wZYnThdgL9kqo15GOpFk/Ssq4mOX2 X-Received: by 10.68.217.225 with SMTP id pb1mr30218317pbc.56.1412214234115; Wed, 01 Oct 2014 18:43:54 -0700 (PDT) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id fn2sm2042218pdb.75.2014.10.01.18.43.52 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 01 Oct 2014 18:43:53 -0700 (PDT) Message-ID: <542CADD8.9070402@igel.co.jp> Date: Thu, 02 Oct 2014 10:43:52 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Neil Horman References: <1412137623-18817-1-git-send-email-mukawa@igel.co.jp> <20141001105022.GB21151@hmsreliant.think-freely.org> In-Reply-To: <20141001105022.GB21151@hmsreliant.think-freely.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] Fix linking errors when CONFIG_RTE_BUILD_SHARED_LIB is enabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Oct 2014 01:37:08 -0000 (2014/10/01 19:50), Neil Horman wrote: > I'm not sure why thats necesecary. We add a --start-group/--end-group = pair > halfway through this makefile. If we just encompassed the entire set o= f > libraries in that group, order would be irrelevant. I haven't known the options. Thanks. Anyway, I understand I shouldn't change link order, but should check why '--start-group/--end-group' doesn't work on my environment. I will describe more in the email for Thomas. Regards, Tetsuya > Neil > >> Signed-off-by: Tetsuya Mukawa >> --- >> mk/rte.app.mk | 16 ++++++++-------- >> 1 file changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/mk/rte.app.mk b/mk/rte.app.mk >> index 34dff2a..172ba4d 100644 >> --- a/mk/rte.app.mk >> +++ b/mk/rte.app.mk >> @@ -121,10 +121,6 @@ endif >> =20 >> LDLIBS +=3D --start-group >> =20 >> -ifeq ($(CONFIG_RTE_LIBRTE_KVARGS),y) >> -LDLIBS +=3D -lrte_kvargs >> -endif >> - >> ifeq ($(CONFIG_RTE_LIBRTE_MBUF),y) >> LDLIBS +=3D -lrte_mbuf >> endif >> @@ -137,6 +133,10 @@ ifeq ($(CONFIG_RTE_LIBRTE_ETHER),y) >> LDLIBS +=3D -lethdev >> endif >> =20 >> +ifeq ($(CONFIG_RTE_LIBRTE_EAL),y) >> +LDLIBS +=3D -lrte_eal >> +endif >> + >> ifeq ($(CONFIG_RTE_LIBRTE_MALLOC),y) >> LDLIBS +=3D -lrte_malloc >> endif >> @@ -158,10 +158,6 @@ ifeq ($(CONFIG_RTE_LIBGLOSS),y) >> LDLIBS +=3D -lgloss >> endif >> =20 >> -ifeq ($(CONFIG_RTE_LIBRTE_EAL),y) >> -LDLIBS +=3D -lrte_eal >> -endif >> - >> ifeq ($(CONFIG_RTE_LIBRTE_CMDLINE),y) >> LDLIBS +=3D -lrte_cmdline >> endif >> @@ -174,6 +170,10 @@ ifeq ($(CONFIG_RTE_LIBRTE_PMD_BOND),y) >> LDLIBS +=3D -lrte_pmd_bond >> endif >> =20 >> +ifeq ($(CONFIG_RTE_LIBRTE_KVARGS),y) >> +LDLIBS +=3D -lrte_kvargs >> +endif >> + >> ifeq ($(CONFIG_RTE_LIBRTE_PMD_XENVIRT),y) >> LDLIBS +=3D -lrte_pmd_xenvirt >> LDLIBS +=3D -lxenstore >> --=20 >> 1.9.1 >> >>