From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id ABB121B06D for ; Fri, 13 Jul 2018 00:37:03 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1FB2F21F3A; Thu, 12 Jul 2018 18:37:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 12 Jul 2018 18:37:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=xMHAQysrQWUybQJ/r5X6Wby4OI AMUR5PiZMm/amOcyM=; b=IGgCfH21SDFIAEtIwOiHbgMq0ZhNC1j+GEKmQco7Ow RSWdFm4Te9QDBZma1+btf3VtQ/WrFn+doZUlT32XBeFP4qeY3AzydxWHID6wBkxP sLzeV/CGPx+X96f5encvzH0x02ffGm/pL2CTdXNECGe09ixgizJC7psIOQWu3afX E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=xMHAQy srQWUybQJ/r5X6Wby4OIAMUR5PiZMm/amOcyM=; b=iYOmnXEki/s20EHi/Az+AS xzCTH4ofDLWeQ42sNu8HwyTRWVsXAerq1MLQvTyaLeVOhLMg5SxGLRx8EUMxgDlp OweE6D2Ybx1p2kgJSsZyqxSE2XMnldMMGNxPwxrAf+bNF0+RsqL8qkiOJmHKJloa yBQjbGAi9G+W5rToeBvKkhGY5UJVgqu8hZAT8xZefkko3jU3fpYXGunLpZnye9Dt 30reysr4zW98sUTtKQXDXxDeKTr3fH6b1HiPeRbUm5faiL/ul+Oscx6VAjcdHLLr YprICBYRotVviuxgngSBZEKijbL3XOwbr45/X0MgwJXbp6sAzAakvLesXnjHDtzg == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4757DE4270; Thu, 12 Jul 2018 18:37:01 -0400 (EDT) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, Jianfeng Tan , Bruce Richardson , konstantin.ananyev@intel.com, qi.z.zhang@intel.com, stephen@networkplumber.org, olivier.matz@6wind.com, david.marchand@6wind.com, ferruh.yigit@intel.com Date: Fri, 13 Jul 2018 00:36:59 +0200 Message-ID: <5431396.k1M6VaMcRs@xps> In-Reply-To: <5f6bc60bf193daf4eb07f4484c52878bb1b751de.1530009564.git.anatoly.burakov@intel.com> References: <5f6bc60bf193daf4eb07f4484c52878bb1b751de.1530009564.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 5/7] eal: bring forward init of interrupt handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2018 22:37:04 -0000 26/06/2018 12:53, Anatoly Burakov: > From: Jianfeng Tan > > Next commit will make asynchronous IPC requests rely on alarm API, > which in turn relies on interrupts to work. Therefore, move the EAL > interrupt initialization before IPC initialization to avoid breaking > IPC in the next commit. > > Signed-off-by: Jianfeng Tan > Signed-off-by: Anatoly Burakov > --- > --- a/lib/librte_eal/linuxapp/eal/eal.c > +++ b/lib/librte_eal/linuxapp/eal/eal.c > @@ -839,6 +839,11 @@ rte_eal_init(int argc, char **argv) > > rte_config_init(); > > + if (rte_eal_intr_init() < 0) { > + rte_eal_init_alert("Cannot init interrupt-handling thread\n"); > + return -1; > + } > + > /* Put mp channel init before bus scan so that we can init the vdev > * bus through mp channel in the secondary process before the bus scan. > */ > @@ -968,11 +973,6 @@ rte_eal_init(int argc, char **argv) > rte_config.master_lcore, (int)thread_id, cpuset, > ret == 0 ? "" : "..."); > > - if (rte_eal_intr_init() < 0) { > - rte_eal_init_alert("Cannot init interrupt-handling thread\n"); > - return -1; > - } > - > RTE_LCORE_FOREACH_SLAVE(i) { I am almost sure it will bring regressions. Please think again about the consequences of initializing interrupt thread before affinity setting, memory init, device init. Opinions / ideas from anyone?