Re: [PATCH v2] app/testpmd: add help messages for multi-process

["Min Hu (Connor)" <humin29@huawei.com>]

Hi, fixed in v3, thanks.

在 2022/3/1 16:35, Thomas Monjalon 写道:
> 01/03/2022 04:39, Min Hu (Connor):
>> From: Huisong Li <lihuisong@huawei.com>
>>
>> This patch adds help messages for multi-process.
>>
>> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>> ---
>> v2:
>> * adjust the position of parameters.
>> ---
>>   app/test-pmd/parameters.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
>> index daf6a31b2b..3e6a2e88b5 100644
>> --- a/app/test-pmd/parameters.c
>> +++ b/app/test-pmd/parameters.c
>> @@ -92,6 +92,8 @@ usage(char* progname)
>>   	printf("  --max-pkt-len=N: set the maximum size of packet to N bytes.\n");
>>   	printf("  --max-lro-pkt-size=N: set the maximum LRO aggregated packet "
>>   	       "size to N bytes.\n");
>> +	printf("  --num-procs: the number of processes which will be used\n");
>> +	printf("  --proc-id  : the id of the current process (id < num-procs)\n");
>>   #ifdef RTE_LIB_CMDLINE
>>   	printf("  --eth-peers-configfile=name: config file with ethernet addresses "
>>   	       "of peer ports.\n");
> 
> Why adding the multiprocess options in the middle of packet and Ethernet config?
> I think it would fit better before --nb-cores.
> 
> Why no testpmd maintainer is Cc'ed?
> Do you know the command --cc-cmd devtools/get-maintainer.sh ?
> 
> 
> .
>