From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84C40A034F; Tue, 1 Mar 2022 10:17:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 216A441C3D; Tue, 1 Mar 2022 10:17:54 +0100 (CET) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id 66891407FF for ; Tue, 1 Mar 2022 10:17:52 +0100 (CET) Received: from dggeme756-chm.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4K7BP40YY7z1GC0C; Tue, 1 Mar 2022 17:13:12 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.21; Tue, 1 Mar 2022 17:17:50 +0800 Subject: Re: [PATCH v2] app/testpmd: add help messages for multi-process To: Thomas Monjalon CC: , References: <20220228032617.46618-1-humin29@huawei.com> <20220301033930.16275-1-humin29@huawei.com> <6212978.1IzOArtZ34@thomas> From: "Min Hu (Connor)" Message-ID: <543b5e25-a5ba-d2b3-e1bd-c7e62197bafc@huawei.com> Date: Tue, 1 Mar 2022 17:17:50 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <6212978.1IzOArtZ34@thomas> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggeme756-chm.china.huawei.com (10.3.19.102) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, fixed in v3, thanks. ÔÚ 2022/3/1 16:35, Thomas Monjalon дµÀ: > 01/03/2022 04:39, Min Hu (Connor): >> From: Huisong Li >> >> This patch adds help messages for multi-process. >> >> Fixes: a550baf24af9 ("app/testpmd: support multi-process") >> Cc: stable@dpdk.org >> >> Signed-off-by: Huisong Li >> --- >> v2: >> * adjust the position of parameters. >> --- >> app/test-pmd/parameters.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c >> index daf6a31b2b..3e6a2e88b5 100644 >> --- a/app/test-pmd/parameters.c >> +++ b/app/test-pmd/parameters.c >> @@ -92,6 +92,8 @@ usage(char* progname) >> printf(" --max-pkt-len=N: set the maximum size of packet to N bytes.\n"); >> printf(" --max-lro-pkt-size=N: set the maximum LRO aggregated packet " >> "size to N bytes.\n"); >> + printf(" --num-procs: the number of processes which will be used\n"); >> + printf(" --proc-id : the id of the current process (id < num-procs)\n"); >> #ifdef RTE_LIB_CMDLINE >> printf(" --eth-peers-configfile=name: config file with ethernet addresses " >> "of peer ports.\n"); > > Why adding the multiprocess options in the middle of packet and Ethernet config? > I think it would fit better before --nb-cores. > > Why no testpmd maintainer is Cc'ed? > Do you know the command --cc-cmd devtools/get-maintainer.sh ? > > > . >