From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Kevin Wilson <wkevils@gmail.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] Kernel Module dependency in DPDK 18.05-rc5 and earlier DPDK releases
Date: Fri, 25 May 2018 16:54:53 +0200 [thread overview]
Message-ID: <5440440.uHIVqB2yed@xps> (raw)
In-Reply-To: <20180525135706.GA23368@bricha3-MOBL.ger.corp.intel.com>
25/05/2018 15:57, Bruce Richardson:
> On Fri, May 25, 2018 at 04:20:42PM +0300, Kevin Wilson wrote:
> > Thanks, Thomas.
> >
> > Actually there is an EAL rte_eal_check_module() method which does this exactly:
> > http://dpdk.org/browse/dpdk/tree/lib/librte_eal/linuxapp/eal/eal.c#n1089
> > It is declared in eal_private.h.
> >
> > Is it reasonable to send a patch which moves the decalartion to eal.h
> > instead so PMDs can use it in their probe() method ?
> >
> > Apart from it - So is there any practical effect for using the
> > RTE_PMD_REGISTER_KMOD_DEP() ? or is it only a sort of declarative
> > macro, saying that the PMD is dependent on the specified kernel
> > modules ? In the past - did it really ever check for dependency and
> > shouted back
> > when the required modules specified in the RTE_PMD_REGISTER_KMOD_DEP()
> > macro were not found ?
> >
> AFAIK this information is only used for reporting out when running pmdinfo
> on a driver or statically linked binary. It was never enforced at runtime,
> simply because the lack of particular ports was never an error. If a module
> was not loaded, and NICs not bound to that module, it was always assumed
> that the ports were never meant to be used by DPDK anyway.
Yes it is informational.
But we can add a log to help with debug.
It could even be an error if a port is whitelisted.
prev parent reply other threads:[~2018-05-25 14:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 9:55 Kevin Wilson
2018-05-25 11:21 ` Thomas Monjalon
2018-05-25 13:20 ` Kevin Wilson
2018-05-25 13:57 ` Bruce Richardson
2018-05-25 14:54 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5440440.uHIVqB2yed@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=wkevils@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).