From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C3B1A0A0A; Fri, 22 Jan 2021 21:57:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E0DC21411AE; Fri, 22 Jan 2021 21:57:22 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id BE12D1411AD for ; Fri, 22 Jan 2021 21:57:20 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id B46A61990; Fri, 22 Jan 2021 15:57:18 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 22 Jan 2021 15:57:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= 2to1aEDQut9q4Teh4OPx67VUQ1fbMzg6mzQhYmG/cUs=; b=20nHjcppAlaoLNLG NQ7W+5adv2WbTXDCyYjg38nTYmGwSK0DHRE0TFQ9D31Gw+8tTpB4zkbUyuXwHAei FiBKdfxQLe4PNFg2v1XoF7niadjO09kGj5rf6RdUj+6F9s7SpIbEJzvrZWezDGNe 3xMbh82BoQzLyhhn4MG7izxLK+tDHfvuO3w9kRfDutq0p01lwN4HsHJbXRyIf66o 9+zbaFZlmCwVAsUgcmi/yG9K4Ka0CiOJj3QICJl8JaTovdIQqTSIYt1bG9HWJXH0 5ES20qT74WY8EXTAt2zAfm7AnPRjBhUYOw1XrRKegqtPnbjTALhlWCj3jn55USe5 9vTqww== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=2to1aEDQut9q4Teh4OPx67VUQ1fbMzg6mzQhYmG/c Us=; b=mZVbsWRmHjaShGhepnIwO8GUVxzgnxJFM41V1BlmcIZS0Y2lG+HG4lxN8 5e8ZCwcNWuwVbzYcCEfI4v+Tv34vr0AvN6khwaiNNnSw3BqDX6lxLQUUirH89pGG Sdo4DO2VGLp33UkLLrBzEQqPyAEwKknab45WLbZForpZJfBVkHBBrSHNwfUE+VLz bR/QaFPaZG1BPvoB6JoCVn01+AP+O5Ng1i94CXN4lueo+m1oGZSUymQ2AlgsNTGy Al3kxsRiHIxsAj2LZtRkJlGgJMuydkUbwczex/wBCcFqJsUa21ZZij3hHAIo83tl WMKHUnl3rENirWlZ4LuZeCgR57i7g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeigddugeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeuhfeitddvvdeuleffhfeifeefudeftefgjeeigffgudetveek veejjeefieelnecuffhomhgrihhnpegrsghighhnohhrvgdrhihouhenucfkphepjeejrd dufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D5C8A108005C; Fri, 22 Jan 2021 15:57:16 -0500 (EST) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, Stephen Hemminger , David Marchand , Maxime Coquelin , Aaron Conole , Bruce Richardson , ferruh.yigit@intel.com, ray.kinsella@intel.com Date: Fri, 22 Jan 2021 21:57:15 +0100 Message-ID: <5444857.Q0qPc8oPp2@thomas> In-Reply-To: <20210122233116.31d1538b@sovereign> References: <20201014183136.22239-1-dmitry.kozliuk@gmail.com> <2534344.1dmFBEvUxf@thomas> <20210122233116.31d1538b@sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 2/3] build: use Python pmdinfogen X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/01/2021 21:31, Dmitry Kozlyuk: > On Wed, 20 Jan 2021 11:24:21 +0100, Thomas Monjalon wrote: > > 20/01/2021 08:23, Dmitry Kozlyuk: > > > On Wed, 20 Jan 2021 01:05:59 +0100, Thomas Monjalon wrote: > > > > This is now the right timeframe to introduce this change > > > > with the new Python module dependency. > > > > Unfortunately, the ABI check is returning an issue: > > > > > > > > 'const char mlx5_common_pci_pmd_info[62]' was changed > > > > to 'const char mlx5_common_pci_pmd_info[60]' at rte_common_mlx5.pmd.c > > > > > > Will investigate and fix ASAP. > > Now that I think of it: strings like this change every time new PCI IDs are > added to a PMD, but AFAIK adding PCI IDs is not considered an ABI breakage, > is it? One example is 28c9a7d7b48e ("net/mlx5: add ConnectX-6 Lx device ID") > added 2020-07-08, i.e. clearly outside of ABI change window. You're right. > "xxx_pmd_info" changes are due to JSON formatting (new is more canonical), > which can be worked around easily, if the above is wrong. If the new format is better, please keep it. What we need is an exception for the pmdinfo symbols in the file devtools/libabigail.abignore. You can probably use a regex for these symbols. > > > > > --- a/meson.build > > > > > +++ b/meson.build > > > > > -subdir('buildtools/pmdinfogen') > > > > > > > > This could be in patch 3 (removing the code). > > > > > > It would redefine "pmdinfogen" variable to old pmdinfogen. > > > Besides, why build what's not used at this patch already? > > > > Just trying to find the best patch split. > > If needed, OK to keep as is. > > I even don't mind squashing all three commits into one. > The split is done to ease the review. I think the split is good as is.