From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <marc.sune@bisdn.de>
Received: from mx.bisdn.de (mx.bisdn.de [185.27.182.31])
 by dpdk.org (Postfix) with ESMTP id A54D56A96
 for <dev@dpdk.org>; Tue, 21 Oct 2014 12:43:27 +0200 (CEST)
Received: from [172.16.251.36] (unknown [172.16.251.36])
 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx.bisdn.de (Postfix) with ESMTPSA id EB560A2DA9;
 Tue, 21 Oct 2014 12:51:41 +0200 (CEST)
Message-ID: <54463ADC.8080901@bisdn.de>
Date: Tue, 21 Oct 2014 12:52:12 +0200
From: Marc Sune <marc.sune@bisdn.de>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:17.0) Gecko/20131103 Icedove/17.0.10
MIME-Version: 1.0
To: Thomas Monjalon <thomas.monjalon@6wind.com>
References: <1413586289-6694-1-git-send-email-marc.sune@bisdn.de>
 <11046523.OQamTbecJT@xps13>
In-Reply-To: <11046523.OQamTbecJT@xps13>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4] KNI: use a memzone pool for KNI
	alloc/release
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Oct 2014 10:43:28 -0000

Thomas,

v5: commit message arranged, all warnings from checkpatch.pl fixed except:

WARNING: Macros with flow control statements should be avoided
#104: FILE: lib/librte_kni/rte_kni.c:62:
+#define KNI_MEM_CHECK(cond) do { if (cond) goto kni_fail; } while (0)

a) This MACRO was there before, I just re-factored it to make it more 
readable.
b) There are 4 lines exceeding 80cols due to long quoted strings. I 
followed kernel convention not to split them in multiple lines.

Thanks and regards
Marc

On 21/10/14 10:29, Thomas Monjalon wrote:
> Hi Marc,
>
> 2014-10-18 00:51, Marc Sune:
>> This patch implements the KNI memzone pool in order to prevent
>> memzone exhaustion when allocating/deallocating KNI interfaces.
>>
>> It adds a new API call, rte_kni_init(max_kni_ifaces) that shall
>> be called before any call to rte_kni_alloc() if KNI is used.
>>
>> v2: Moved KNI fd opening to rte_kni_init(). Revised style.
>> v3: Adapted kni examples/tests to rte_kni_init().
>> v4: Improved example integration. Fixed kni_memzone_pool_alloc/release() bug.
>>
>> Signed-off-by: Marc Sune <marc.sune@bisdn.de>
> Thanks for the good work with Helin.
> Before applying this patch, I'd like another version explaining in the
> commit log why this change is needed.
> And please use to checkpatch.pl to check and remove whitespace errors.
>
> Thanks