From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 19DC2A034F;
Mon, 22 Mar 2021 09:56:00 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id CE38E40040;
Mon, 22 Mar 2021 09:55:59 +0100 (CET)
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com
[64.147.123.25])
by mails.dpdk.org (Postfix) with ESMTP id E258E4003D;
Mon, 22 Mar 2021 09:55:58 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
by mailout.west.internal (Postfix) with ESMTP id B5FF815D4;
Mon, 22 Mar 2021 04:55:54 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute2.internal (MEProxy); Mon, 22 Mar 2021 04:55:55 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm3; bh=
7UoadcHP9wFHlimpUyvJI2Id24leuNJNSqEv0Xy2VJs=; b=VAEUsrlEZ2+hHCmJ
Li8dCIGNCCdOJHH4aNo7X/dKFgaqBSHQjIQgQSsgRA/lKDpGBTkRFLDZvkdfiNC/
+iJWCDewYCAz6U9JSvFED/WnZymWtuMKVMKuozcj7jZiwiYKgya2Qw4V8cGhW+O9
UBOoPEcYNOAUezY9jDzfuDDvk1Pv+Vwl1IbC+waKtN7dNHZJZZskuuAk5z8Z/S5K
T3We5NAF/vsKbIYXkFEC/Q3wEV3TgLfmI/oPxt0QSIF+RpDZltuavJjM076skliF
1B/lU9i+vdwUJ8M/o/+lV3jcnINITepnmgxqe5AJTylnwtLk/7Zv6MtuNLSdDuxi
tlrn1g==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=7UoadcHP9wFHlimpUyvJI2Id24leuNJNSqEv0Xy2V
Js=; b=knwpDsDy3//kFPw4k1SXgbhUs+TKz/xxZeVVvmHqLZTJofvS+c7otGtq6
LnTmXlPuUzoM40oVSRdNpuLXC2RQ6C2A50bsZaPW9WToXS3W/3FtYcDhrqUqQHfu
P4Pba3ZpjhAAPnPWVXa6fnMNvIfbkYfGVwS0QYe0/wR5pSSk9ifb8ockvrJvOYf5
58LpxootBGhupCvYJI/GyDIqOFbfds31U0r+63jKlOBhbWULpFQ+PydcZnPa2gkG
xZqL8KeNBQgePzQI4UWafejNKqcdAYuhykidgAAiF6MBPlZ3ngRKC0ne+mG8kIbN
t80Ajw7LNhmXgptldZXZrZPkuq/sA==
X-ME-Sender: <xms:mVtYYLo3sWFOJf3V1XzXxYXQkyCNFlamLwThW8tt5WwawFjnek4SSQ>
<xme:mVtYYFry88M_NCSxNkWJWGhVlTR341hYbpsMfr0E4vNVkBQw_M8LdGL5WUGwReAg4
pCPgLAYhncEq6zMQA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudegfedguddvjecutefuodetggdotefrod
ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm
rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej
ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh
fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr
lhhonhdrnhgvth
X-ME-Proxy: <xmx:mVtYYINk8wicaDKPC-ZzzAx1oS9DPHiekriHKp0H2Tt-jHXXWkI63A>
<xmx:mVtYYO7plgPDOBL4nDpqTJbFckAp0YpRShK4267t7w8NUYRK12x0hg>
<xmx:mVtYYK4yGWUREoUln9qVO7qSAZ5QeOHy8Bq80oIFh8kQ_cQv1Qp7fA>
<xmx:mltYYBbHBiyMdcUwWyuMixbgiB2MiIHSQepiFOc2slQ8k6fxc5FO0A>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 1AFB924033F;
Mon, 22 Mar 2021 04:55:52 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Kinsella, Ray" <mdr@ashroe.eu>
Cc: dev@dpdk.org, ncopa@alpinelinux.org, stable@dpdk.org,
Bruce Richardson <bruce.richardson@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
David Marchand <david.marchand@redhat.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Haiyue Wang <haiyue.wang@intel.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>
Date: Mon, 22 Mar 2021 09:55:50 +0100
Message-ID: <5446580.tqp9qgG6IV@thomas>
In-Reply-To: <139ba04c-4b63-9686-a123-3f3e1e23077b@ashroe.eu>
References: <20190313170657.16688-1-ncopa@alpinelinux.org>
<20210319145730.3555384-3-thomas@monjalon.net>
<139ba04c-4b63-9686-a123-3f3e1e23077b@ashroe.eu>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v7 02/17] buildtools: fix build with busybox
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
22/03/2021 09:52, Kinsella, Ray:
> On 19/03/2021 14:57, Thomas Monjalon wrote:
> > --- a/buildtools/check-symbols.sh
> > +++ b/buildtools/check-symbols.sh
> > -DUMPFILE=$(mktemp -t dpdk.${0##*/}.XXX.objdump)
> > +DUMPFILE=$(mktemp -t dpdk.${0##*/}.XXXXXX)
>
> Does it make sense to change it to
>
> DUMPFILE=$(mktemp -t dpdk.${0##*/}.objdump.XXXXXX)
>
> So we can preserve what the file is in the filename?
Yes could be.
There is already the name of the script in the temp filename,
but I am OK to add more details.
If there is no other comment, I will change when applying.