From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx.bisdn.de (mx.bisdn.de [185.27.182.31]) by dpdk.org (Postfix) with ESMTP id 8FDDA7E80 for ; Wed, 22 Oct 2014 09:05:12 +0200 (CEST) Received: from [172.16.251.36] (unknown [172.16.251.36]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx.bisdn.de (Postfix) with ESMTPSA id 170A8A2DA9; Wed, 22 Oct 2014 09:13:30 +0200 (CEST) Message-ID: <54475938.9040305@bisdn.de> Date: Wed, 22 Oct 2014 09:14:00 +0200 From: Marc Sune User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 MIME-Version: 1.0 To: "Liu, Jijiang" References: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D8288F@SHSMSX101.ccr.corp.intel.com> <1413961851-13230-1-git-send-email-marc.sune@bisdn.de> In-Reply-To: <1413961851-13230-1-git-send-email-marc.sune@bisdn.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "" Subject: Re: [dpdk-dev] [PATCH] KNI: fix compilation warning 'missing-field-initializers' X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Oct 2014 07:05:12 -0000 Liu, Can you confirm that this patch fixes the issue? Thanks marc On 22/10/14 09:10, Marc Sune wrote: > Fix for compilation warning 'missing-field-initializers' for some > GCC and clang versions introduced in commit 0c6bc8e > > Signed-off-by: Marc Sune > --- > lib/librte_kni/rte_kni.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_kni/rte_kni.c b/lib/librte_kni/rte_kni.c > index f64a0a8..de29b99 100644 > --- a/lib/librte_kni/rte_kni.c > +++ b/lib/librte_kni/rte_kni.c > @@ -131,7 +131,14 @@ static void kni_free_mbufs(struct rte_kni *kni); > static void kni_allocate_mbufs(struct rte_kni *kni); > > static volatile int kni_fd = -1; > -static struct rte_kni_memzone_pool kni_memzone_pool = {0}; > +static struct rte_kni_memzone_pool kni_memzone_pool = { > + .initialized = 0, > + .max_ifaces = 0, > + .slots = 0, > + .mutex = RTE_SPINLOCK_INITIALIZER, > + .free = NULL, > + .free_tail = NULL > +}; > > static const struct rte_memzone * > kni_memzone_reserve(const char *name, size_t len, int socket_id,