From: Jincheng Miao <jmiao@redhat.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: replace strict_strtoul with kstrtoul
Date: Thu, 30 Oct 2014 10:30:23 +0800 [thread overview]
Message-ID: <5451A2BF.50108@redhat.com> (raw)
In-Reply-To: <32178779.LGXfgoCJ7N@xps13>
On 10/30/2014 08:04 AM, Thomas Monjalon wrote:
> Hi Jincheng,
>
> 2014-10-24 15:07, Jincheng Miao:
>> From upstream kernel commit 3db2e9cd, strict_strto* serial functions
>> are removed. So that we should directly used kstrtoul instead.
> kstrtoul appeared in version 2.6.39 in commit 33ee3b2e2eb9b
> ("kstrto*: converting strings to integers done (hopefully) right")
>
> So we need a compatibility fallback.
Hi Thomas,
The solution could be simple, we could check the version of kernel,
and define a macro kstrtoul for old kernel.
Regards & thanks,
Jincheng Miao
>
> Thanks
prev parent reply other threads:[~2014-10-30 2:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 7:07 Jincheng Miao
2014-10-30 0:04 ` Thomas Monjalon
2014-10-30 2:30 ` Jincheng Miao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5451A2BF.50108@redhat.com \
--to=jmiao@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).