From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jmiao@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 929F86835
 for <dev@dpdk.org>; Thu, 30 Oct 2014 03:23:20 +0100 (CET)
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
 (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
 by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9U2WBb0016861
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL);
 Wed, 29 Oct 2014 22:32:12 -0400
Received: from dhcp-66-71-51.eng.nay.redhat.com
 (dhcp-66-71-51.eng.nay.redhat.com [10.66.71.51] (may be forged))
 by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 s9U2W9r8008181; Wed, 29 Oct 2014 22:32:10 -0400
Message-ID: <5451A2BF.50108@redhat.com>
Date: Thu, 30 Oct 2014 10:30:23 +0800
From: Jincheng Miao <jmiao@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: Thomas Monjalon <thomas.monjalon@6wind.com>
References: <1414134451-1511-1-git-send-email-jmiao@redhat.com>
 <32178779.LGXfgoCJ7N@xps13>
In-Reply-To: <32178779.LGXfgoCJ7N@xps13>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: replace strict_strtoul with kstrtoul
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Oct 2014 02:23:21 -0000


On 10/30/2014 08:04 AM, Thomas Monjalon wrote:
> Hi Jincheng,
>
> 2014-10-24 15:07, Jincheng Miao:
>>  From upstream kernel commit 3db2e9cd, strict_strto* serial functions
>> are removed. So that we should directly used kstrtoul instead.
> kstrtoul appeared in version 2.6.39 in commit 33ee3b2e2eb9b
> ("kstrto*: converting strings to integers done (hopefully) right")
>
> So we need a compatibility fallback.

Hi Thomas,

The solution could be simple, we could check the version of kernel,
and define a macro kstrtoul for old kernel.

Regards & thanks,
Jincheng Miao


>
> Thanks