* [PATCH] pipeline: fix comparison
@ 2022-06-13 11:52 Cristian Dumitrescu
2022-06-15 19:06 ` Thomas Monjalon
2022-06-16 9:14 ` [PATCH V2] pipeline: fix check against max number of learner table timeouts Cristian Dumitrescu
0 siblings, 2 replies; 5+ messages in thread
From: Cristian Dumitrescu @ 2022-06-13 11:52 UTC (permalink / raw)
To: dev; +Cc: Harshad Narayane
From: Harshad Narayane <harshad.suresh.narayane@intel.com>
Fix comparison used to check against the maximum number of learner
table timeouts.
Fixes: e2ecc53582fb ("pipeline: improve learner table timers")
Signed-off-by: Harshad Narayane <harshad.suresh.narayane@intel.com>
Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
lib/pipeline/rte_swx_pipeline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/pipeline/rte_swx_pipeline.c b/lib/pipeline/rte_swx_pipeline.c
index b4b44ad897..659d8726d1 100644
--- a/lib/pipeline/rte_swx_pipeline.c
+++ b/lib/pipeline/rte_swx_pipeline.c
@@ -8848,7 +8848,7 @@ rte_swx_pipeline_learner_config(struct rte_swx_pipeline *p,
/* Any other checks. */
CHECK(size, EINVAL);
CHECK(timeout, EINVAL);
- CHECK(n_timeouts && (n_timeouts < RTE_SWX_TABLE_LEARNER_N_KEY_TIMEOUTS_MAX), EINVAL);
+ CHECK(n_timeouts && (n_timeouts <= RTE_SWX_TABLE_LEARNER_N_KEY_TIMEOUTS_MAX), EINVAL);
/* Memory allocation. */
l = calloc(1, sizeof(struct learner));
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pipeline: fix comparison
2022-06-13 11:52 [PATCH] pipeline: fix comparison Cristian Dumitrescu
@ 2022-06-15 19:06 ` Thomas Monjalon
2022-06-16 9:17 ` Dumitrescu, Cristian
2022-06-16 9:14 ` [PATCH V2] pipeline: fix check against max number of learner table timeouts Cristian Dumitrescu
1 sibling, 1 reply; 5+ messages in thread
From: Thomas Monjalon @ 2022-06-15 19:06 UTC (permalink / raw)
To: Harshad Narayane, Cristian Dumitrescu; +Cc: dev
13/06/2022 13:52, Cristian Dumitrescu:
> From: Harshad Narayane <harshad.suresh.narayane@intel.com>
>
> Fix comparison used to check against the maximum number of learner
> table timeouts.
>
> Fixes: e2ecc53582fb ("pipeline: improve learner table timers")
The title is not informative about what is fixed.
Please give a bit of scope so people experiencing an issue
will know it is fixed.
You can at least give the words "learner table timers"
and maybe "check of maximum".
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH V2] pipeline: fix check against max number of learner table timeouts
2022-06-13 11:52 [PATCH] pipeline: fix comparison Cristian Dumitrescu
2022-06-15 19:06 ` Thomas Monjalon
@ 2022-06-16 9:14 ` Cristian Dumitrescu
2022-06-20 14:07 ` Thomas Monjalon
1 sibling, 1 reply; 5+ messages in thread
From: Cristian Dumitrescu @ 2022-06-16 9:14 UTC (permalink / raw)
To: dev; +Cc: Harshad Narayane
From: Harshad Narayane <harshad.suresh.narayane@intel.com>
Fix comparison used to check against the maximum number of learner
table timeouts.
Fixes: e2ecc53582fb ("pipeline: improve learner table timers")
Signed-off-by: Harshad Narayane <harshad.suresh.narayane@intel.com>
Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
lib/pipeline/rte_swx_pipeline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/pipeline/rte_swx_pipeline.c b/lib/pipeline/rte_swx_pipeline.c
index b4b44ad897..659d8726d1 100644
--- a/lib/pipeline/rte_swx_pipeline.c
+++ b/lib/pipeline/rte_swx_pipeline.c
@@ -8848,7 +8848,7 @@ rte_swx_pipeline_learner_config(struct rte_swx_pipeline *p,
/* Any other checks. */
CHECK(size, EINVAL);
CHECK(timeout, EINVAL);
- CHECK(n_timeouts && (n_timeouts < RTE_SWX_TABLE_LEARNER_N_KEY_TIMEOUTS_MAX), EINVAL);
+ CHECK(n_timeouts && (n_timeouts <= RTE_SWX_TABLE_LEARNER_N_KEY_TIMEOUTS_MAX), EINVAL);
/* Memory allocation. */
l = calloc(1, sizeof(struct learner));
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] pipeline: fix comparison
2022-06-15 19:06 ` Thomas Monjalon
@ 2022-06-16 9:17 ` Dumitrescu, Cristian
0 siblings, 0 replies; 5+ messages in thread
From: Dumitrescu, Cristian @ 2022-06-16 9:17 UTC (permalink / raw)
To: Thomas Monjalon, Suresh Narayane, Harshad; +Cc: dev
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, June 15, 2022 8:06 PM
> To: Suresh Narayane, Harshad <harshad.suresh.narayane@intel.com>;
> Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [PATCH] pipeline: fix comparison
>
> 13/06/2022 13:52, Cristian Dumitrescu:
> > From: Harshad Narayane <harshad.suresh.narayane@intel.com>
> >
> > Fix comparison used to check against the maximum number of learner
> > table timeouts.
> >
> > Fixes: e2ecc53582fb ("pipeline: improve learner table timers")
>
> The title is not informative about what is fixed.
> Please give a bit of scope so people experiencing an issue
> will know it is fixed.
> You can at least give the words "learner table timers"
> and maybe "check of maximum".
>
>
Thanks, Thomas, done in V2 just sent out:
https://patches.dpdk.org/project/dpdk/list/?series=23562
Regards,
Cristian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2] pipeline: fix check against max number of learner table timeouts
2022-06-16 9:14 ` [PATCH V2] pipeline: fix check against max number of learner table timeouts Cristian Dumitrescu
@ 2022-06-20 14:07 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2022-06-20 14:07 UTC (permalink / raw)
To: Cristian Dumitrescu; +Cc: dev, Harshad Narayane
16/06/2022 11:14, Cristian Dumitrescu:
> From: Harshad Narayane <harshad.suresh.narayane@intel.com>
>
> Fix comparison used to check against the maximum number of learner
> table timeouts.
>
> Fixes: e2ecc53582fb ("pipeline: improve learner table timers")
>
> Signed-off-by: Harshad Narayane <harshad.suresh.narayane@intel.com>
> Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-06-20 14:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-13 11:52 [PATCH] pipeline: fix comparison Cristian Dumitrescu
2022-06-15 19:06 ` Thomas Monjalon
2022-06-16 9:17 ` Dumitrescu, Cristian
2022-06-16 9:14 ` [PATCH V2] pipeline: fix check against max number of learner table timeouts Cristian Dumitrescu
2022-06-20 14:07 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).