From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e23smtp07.au.ibm.com (e23smtp07.au.ibm.com [202.81.31.140]) by dpdk.org (Postfix) with ESMTP id 230832A9 for ; Wed, 5 Nov 2014 03:31:03 +0100 (CET) Received: from /spool/local by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 5 Nov 2014 12:40:21 +1000 Received: from d23dlp02.au.ibm.com (202.81.31.213) by e23smtp07.au.ibm.com (202.81.31.204) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 5 Nov 2014 12:40:19 +1000 Received: from d23relay07.au.ibm.com (d23relay07.au.ibm.com [9.190.26.37]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 489292BB0057 for ; Wed, 5 Nov 2014 13:40:19 +1100 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay07.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id sA52e6Gs39780394 for ; Wed, 5 Nov 2014 13:40:14 +1100 Received: from d23av03.au.ibm.com (localhost [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id sA52dkO9016247 for ; Wed, 5 Nov 2014 13:39:46 +1100 Received: from [127.0.0.1] ([9.186.104.230]) by d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id sA52dh7d015791; Wed, 5 Nov 2014 13:39:45 +1100 Message-ID: <54598DFC.6070006@linux.vnet.ibm.com> Date: Wed, 05 Nov 2014 10:39:56 +0800 From: Chao Zhu User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: David Marchand , dev@dpdk.org References: <1414500657-23774-1-git-send-email-david.marchand@6wind.com> In-Reply-To: <1414500657-23774-1-git-send-email-david.marchand@6wind.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14110502-0025-0000-0000-0000006EB42B Cc: bjzhuc@cn.ibm.com Subject: Re: [dpdk-dev] [PATCH v3 00/10] split architecture specific operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Nov 2014 02:31:05 -0000 > The set of patches split x86 architecture specific operations from DPDK and put > them to x86 arch directory. > This will make the adoption of DPDK much easier on other computer architecture. > For a new architecture, just add an architecture specific directory and > necessary building configuration files, then DPDK eal library can support it. > > > Reviewing patchset from Chao, I ended up modifying it along the way, > so here is a new iteration of this patchset. > > Changes since Chao v2 patchset : > > - added a preliminary patch for moving rte_atomic.h (for better readability) > - fixed documentation generation > - implemented a generic header for each arch specific header (cpuflags, memcpy, > prefetch were missing) > - removed C++ stuff from generic headers > - centralised all doxygen stuff in generic headers (no need to have duplicates) > - refactored rte_cycles functions > - moved vmware tsc stuff to arch rte_cycles.h headers > - finished x86 factorisation > > > Little summary of current state : > > - all applications continue to include the eal headers as before, these headers > are the arch-specific ones > - the arch specific headers always include the generic ones. The generic headers > contain the doxygen documentation and code common to all architectures > - a x86 architecture has been defined which handles both 32bits and 64bits > peculiarities > > > It builds fine for 32/64 bits (w and w/o "force intrinsics"), but I really would > like a lot of eyes on this (and I would say, especially, rte_cycles, rte_memcpy > and rte_cpuflags). > I still have some concerns about the use of intrinsics for architecture != x86 > but I think Chao will be the best to look at this. > > Acked-by: Chao Zhu