DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tetsuya Mukawa <mukawa@igel.co.jp>
To: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/2] lib/librte_vhost: coding style fixes
Date: Fri, 07 Nov 2014 12:16:53 +0900	[thread overview]
Message-ID: <545C39A5.50209@igel.co.jp> (raw)
In-Reply-To: <1415249165-24634-1-git-send-email-huawei.xie@intel.com>

Hi Xie,

Do you have a plan to fix coding style of 'librte_vhost/vhost-net-cdev.h'?
Especially, PRINT_PACKET macro.

Thanks,
Tetsuya

(2014/11/06 13:46), Huawei Xie wrote:
> This patchset fixes serious coding style issues in vhost library.
>
> Huawei Xie (2):
>   fix alignment, lengthy lines, misordered type and other style issues 
>   printk -> pr_debug
>
>  lib/librte_vhost/eventfd_link/eventfd_link.c | 244 ++++++++++-----------
>  lib/librte_vhost/eventfd_link/eventfd_link.h | 127 ++++++-----
>  lib/librte_vhost/rte_virtio_net.h            |   3 +-
>  lib/librte_vhost/vhost-net-cdev.c            | 187 +++++++++-------
>  lib/librte_vhost/vhost_rxtx.c                |  13 +-
>  lib/librte_vhost/virtio-net.c                | 317 +++++++++++++++++----------
>  6 files changed, 494 insertions(+), 397 deletions(-)
>

      parent reply	other threads:[~2014-11-07  3:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-06  4:46 Huawei Xie
2014-11-06 10:22 ` De Lara Guarch, Pablo
2014-11-07  3:16 ` Tetsuya Mukawa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=545C39A5.50209@igel.co.jp \
    --to=mukawa@igel.co.jp \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).