DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 0/2] lib/librte_vhost: coding style fixes
@ 2014-11-06  4:46 Huawei Xie
  2014-11-06 10:22 ` De Lara Guarch, Pablo
  2014-11-07  3:16 ` Tetsuya Mukawa
  0 siblings, 2 replies; 3+ messages in thread
From: Huawei Xie @ 2014-11-06  4:46 UTC (permalink / raw)
  To: dev

This patchset fixes serious coding style issues in vhost library.

Huawei Xie (2):
  fix alignment, lengthy lines, misordered type and other style issues 
  printk -> pr_debug

 lib/librte_vhost/eventfd_link/eventfd_link.c | 244 ++++++++++-----------
 lib/librte_vhost/eventfd_link/eventfd_link.h | 127 ++++++-----
 lib/librte_vhost/rte_virtio_net.h            |   3 +-
 lib/librte_vhost/vhost-net-cdev.c            | 187 +++++++++-------
 lib/librte_vhost/vhost_rxtx.c                |  13 +-
 lib/librte_vhost/virtio-net.c                | 317 +++++++++++++++++----------
 6 files changed, 494 insertions(+), 397 deletions(-)

-- 
1.8.1.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH 0/2] lib/librte_vhost: coding style fixes
  2014-11-06  4:46 [dpdk-dev] [PATCH 0/2] lib/librte_vhost: coding style fixes Huawei Xie
@ 2014-11-06 10:22 ` De Lara Guarch, Pablo
  2014-11-07  3:16 ` Tetsuya Mukawa
  1 sibling, 0 replies; 3+ messages in thread
From: De Lara Guarch, Pablo @ 2014-11-06 10:22 UTC (permalink / raw)
  To: Xie, Huawei; +Cc: dev

Hi Huawei,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Huawei Xie
> Sent: Thursday, November 06, 2014 4:46 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 0/2] lib/librte_vhost: coding style fixes
> 
> This patchset fixes serious coding style issues in vhost library.
> 
> Huawei Xie (2):
>   fix alignment, lengthy lines, misordered type and other style issues
>   printk -> pr_debug
> 
>  lib/librte_vhost/eventfd_link/eventfd_link.c | 244 ++++++++++-----------
>  lib/librte_vhost/eventfd_link/eventfd_link.h | 127 ++++++-----
>  lib/librte_vhost/rte_virtio_net.h            |   3 +-
>  lib/librte_vhost/vhost-net-cdev.c            | 187 +++++++++-------
>  lib/librte_vhost/vhost_rxtx.c                |  13 +-
>  lib/librte_vhost/virtio-net.c                | 317 +++++++++++++++++----------
>  6 files changed, 494 insertions(+), 397 deletions(-)
> 
> --
> 1.8.1.4

I assume this is the cover letter of the two patches that you sent 5 hours before. 
You should probably send this again, as it seems to not be connected to the patches 
(look here: http://dpdk.org/ml/archives/dev/2014-November/)


Thanks,
Pablo

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH 0/2] lib/librte_vhost: coding style fixes
  2014-11-06  4:46 [dpdk-dev] [PATCH 0/2] lib/librte_vhost: coding style fixes Huawei Xie
  2014-11-06 10:22 ` De Lara Guarch, Pablo
@ 2014-11-07  3:16 ` Tetsuya Mukawa
  1 sibling, 0 replies; 3+ messages in thread
From: Tetsuya Mukawa @ 2014-11-07  3:16 UTC (permalink / raw)
  To: dev

Hi Xie,

Do you have a plan to fix coding style of 'librte_vhost/vhost-net-cdev.h'?
Especially, PRINT_PACKET macro.

Thanks,
Tetsuya

(2014/11/06 13:46), Huawei Xie wrote:
> This patchset fixes serious coding style issues in vhost library.
>
> Huawei Xie (2):
>   fix alignment, lengthy lines, misordered type and other style issues 
>   printk -> pr_debug
>
>  lib/librte_vhost/eventfd_link/eventfd_link.c | 244 ++++++++++-----------
>  lib/librte_vhost/eventfd_link/eventfd_link.h | 127 ++++++-----
>  lib/librte_vhost/rte_virtio_net.h            |   3 +-
>  lib/librte_vhost/vhost-net-cdev.c            | 187 +++++++++-------
>  lib/librte_vhost/vhost_rxtx.c                |  13 +-
>  lib/librte_vhost/virtio-net.c                | 317 +++++++++++++++++----------
>  6 files changed, 494 insertions(+), 397 deletions(-)
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-11-07  3:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-06  4:46 [dpdk-dev] [PATCH 0/2] lib/librte_vhost: coding style fixes Huawei Xie
2014-11-06 10:22 ` De Lara Guarch, Pablo
2014-11-07  3:16 ` Tetsuya Mukawa

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git