From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f171.google.com (mail-pd0-f171.google.com [209.85.192.171]) by dpdk.org (Postfix) with ESMTP id B37732E89 for ; Fri, 7 Nov 2014 04:07:28 +0100 (CET) Received: by mail-pd0-f171.google.com with SMTP id r10so2427694pdi.16 for ; Thu, 06 Nov 2014 19:16:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=9VhlgVEEm4opweN91zdf23BvAXO9LBswL4RdrGuvzpc=; b=HL4cTTnM9tudKl0JwLptE1mIWj0UmxAzb9mooCR4lHG6ucyiFbFxQyXCXEqkOo72dD Owx2kLXZoUGDbWpX1DhlP2i5ug7kZX2PuOWQeYJZoTP+hsv95WyQALCyvt+uPBMD6Pn7 MAqXlSsWN9uME1MgXPjsXzZhXTfnYX0iGapAPHU2mjZ4KLNDClqh1zUuyEd8DwAHQA3V j8WG11AexDBKu3rKl3ppROsF9NHRJlZC44ayJUL9nxliRWkLL5o1/Uz60QUzpJftb9f1 Y1UnlybyPCTjp4pkpmkdHCIwnQjJPXfzeBrgkJ2YqfuJFEf+OzVrtWeEmrI00g+5Szm1 H6Ng== X-Gm-Message-State: ALoCoQnPDJXt2F7isj4BkAk8fPEv1PRkCH36BeuDLfYpDH4k4yoNplsD+Beo9LM2S98dGfG3xl1/ X-Received: by 10.70.87.168 with SMTP id az8mr9029597pdb.55.1415330217778; Thu, 06 Nov 2014 19:16:57 -0800 (PST) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id dj1sm7229308pdb.10.2014.11.06.19.16.54 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 06 Nov 2014 19:16:57 -0800 (PST) Message-ID: <545C39A5.50209@igel.co.jp> Date: Fri, 07 Nov 2014 12:16:53 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: dev@dpdk.org References: <1415249165-24634-1-git-send-email-huawei.xie@intel.com> In-Reply-To: <1415249165-24634-1-git-send-email-huawei.xie@intel.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 0/2] lib/librte_vhost: coding style fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Nov 2014 03:07:29 -0000 Hi Xie, Do you have a plan to fix coding style of 'librte_vhost/vhost-net-cdev.h'? Especially, PRINT_PACKET macro. Thanks, Tetsuya (2014/11/06 13:46), Huawei Xie wrote: > This patchset fixes serious coding style issues in vhost library. > > Huawei Xie (2): > fix alignment, lengthy lines, misordered type and other style issues > printk -> pr_debug > > lib/librte_vhost/eventfd_link/eventfd_link.c | 244 ++++++++++----------- > lib/librte_vhost/eventfd_link/eventfd_link.h | 127 ++++++----- > lib/librte_vhost/rte_virtio_net.h | 3 +- > lib/librte_vhost/vhost-net-cdev.c | 187 +++++++++------- > lib/librte_vhost/vhost_rxtx.c | 13 +- > lib/librte_vhost/virtio-net.c | 317 +++++++++++++++++---------- > 6 files changed, 494 insertions(+), 397 deletions(-) >