From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id D0B2A7F2C for ; Mon, 10 Nov 2014 21:45:19 +0100 (CET) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Xnw28-0001v5-AV; Mon, 10 Nov 2014 21:58:08 +0100 Message-ID: <54612615.1050405@6wind.com> Date: Mon, 10 Nov 2014 21:54:45 +0100 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 MIME-Version: 1.0 To: Bruce Richardson References: <1415635166-1364-1-git-send-email-olivier.matz@6wind.com> <1415635166-1364-7-git-send-email-olivier.matz@6wind.com> <20141110171905.GF10776@bricha3-MOBL3> In-Reply-To: <20141110171905.GF10776@bricha3-MOBL3> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: jigsaw@gmail.com, dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 06/12] mbuf: add functions to get the name of an ol_flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Nov 2014 20:45:20 -0000 Hi Bruce, Thank you for the review. On 11/10/2014 06:29 PM, Bruce Richardson wrote: >> +/** >> + * Bit Mask to indicate what bits required for building TX context > > I don't understand this first line - is it accidentally included? Right, it's a mistake, I'll remove this line. >> + * Get the name of a RX offload flag >> + * >> + * @param mask >> + * The mask describing the flag. Usually only one bit must be set. >> + * Several bits can be given if they belong to the same mask. >> + * Ex: PKT_TX_L4_MASK. > TX mask given as an example for a function for RX flags is confusing. I'll remove the last two lines of the description as there is no example for RX flags. Regards, Olivier