From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id DAEC37E75
 for <dev@dpdk.org>; Wed, 12 Nov 2014 18:34:17 +0100 (CET)
Received: by mail-wg0-f46.google.com with SMTP id x13so15036402wgg.5
 for <dev@dpdk.org>; Wed, 12 Nov 2014 09:44:13 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
 :cc:subject:references:in-reply-to:content-type
 :content-transfer-encoding;
 bh=3kTIDcp0dcivFEvHgdzY3sL7fHdVerq1UxeSC3g5vTc=;
 b=dJg1j/eTUmUMoWoQo2uyjGAQ1eh6yUaspN/v87We1h3d94h3h2WGOic9qrOOuSgoug
 nFaNledyk1UKbfJO+A12UOKRJjIXGDZLC1/b4E77D5y7NLHBzBjsLA2h32xfa6icWuYT
 YtXohchNALqxZOXYVSl/qufsri06TwtJeREz0J67sszkFxwgcrNpfsTP30ddiE2cfDbV
 spALxt5vHjNINStjNc9Lq7uSHC3+NV80ZraojrBVFV0+aGmuf2wvk8ms97KmyEWDviXU
 8eifjeWOJXp9VaVyHDZcK4j2yn5XjTOIX+0ST/Ucr8xX+44AMF6D57Cmr+oPVl6Q1ula
 +6Wg==
X-Gm-Message-State: ALoCoQnYKEZbp9rnAtkyfXQNfi/Z1DePMDy1Vbdfpfum4d9d0sOqp04UGSUxNb9EOoXLThnx9qiI
X-Received: by 10.195.12.136 with SMTP id eq8mr63314711wjd.77.1415814252951;
 Wed, 12 Nov 2014 09:44:12 -0800 (PST)
Received: from [10.16.0.195] (guy78-3-82-239-227-177.fbx.proxad.net.
 [82.239.227.177])
 by mx.google.com with ESMTPSA id ua8sm32293015wjc.7.2014.11.12.09.44.11
 for <multiple recipients>
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Wed, 12 Nov 2014 09:44:12 -0800 (PST)
Message-ID: <54639C6B.2010706@6wind.com>
Date: Wed, 12 Nov 2014 18:44:11 +0100
From: Olivier MATZ <olivier.matz@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:24.0) Gecko/20100101 Icedove/24.5.0
MIME-Version: 1.0
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, 
 "Richardson, Bruce" <bruce.richardson@intel.com>
References: <1415635166-1364-1-git-send-email-olivier.matz@6wind.com>
 <1415635166-1364-7-git-send-email-olivier.matz@6wind.com>
 <20141110171905.GF10776@bricha3-MOBL3>
 <2601191342CEEE43887BDE71AB977258213A41C6@IRSMSX105.ger.corp.intel.com>
In-Reply-To: <2601191342CEEE43887BDE71AB977258213A41C6@IRSMSX105.ger.corp.intel.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>, "jigsaw@gmail.com" <jigsaw@gmail.com>
Subject: Re: [dpdk-dev] [PATCH 06/12] mbuf: add functions to get the name of
	an ol_flag
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Nov 2014 17:34:18 -0000

Hi Konstantin,

On 11/12/2014 06:21 PM, Ananyev, Konstantin wrote:
>>> This patch introduces 2 new functions rte_get_rx_ol_flag_name()
>>> and rte_get_tx_ol_flag_name() that returns the name of a flag from
>>> its mask. It also fixes rxonly.c to use this new functions and to
>>> display the proper flags.
>>
>> Good idea. Couple of minor comments below.
>
> Yes, that looks like a good idea to me too.
> Just one thought - there is probably no need to make rte_get_*_ol_flag_name() inlined
> and put  them into rte_mbuf.h
> Seems like rte_mbuf.c - is a good place for these 2 functions definitions.
>
> Konstantin
>

Agree, I'll add this change to the list.

Thanks,
Olivier