From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f174.google.com (mail-pd0-f174.google.com [209.85.192.174]) by dpdk.org (Postfix) with ESMTP id 7E3DD7E75 for ; Fri, 14 Nov 2014 06:02:56 +0100 (CET) Received: by mail-pd0-f174.google.com with SMTP id p10so15862531pdj.5 for ; Thu, 13 Nov 2014 21:12:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=U4ELOIuBHpGBsSsZBGzB1sgslX1eqsgbCPTO6SY86kY=; b=HDgG85jcDYEKsIovn4JniOcR8SKvLupNEbhHTJfHymr2TRxADerK22gSxVocH3yMFu 4VRTfogsBK1MgcO+ovEE4mce3lCzs8oaRrRNlI3f65biy/iF5ONxWu8oIMwLjSA8j4k0 35nkVyqPmKHY66SDcAJDyBgKTAuIn9k4bpjNo/ZJ7GYHGJiRepD5SKaiWNGN94i1ct19 C1W4mCQDAcXnZVBsG0Cs3Sh2HYq+T/ohoOB1wnEIBt1NGkinm2dKLspndzj/VDWMTPd+ t2ETnuNiZlabOUr6A7uh6yipkvLfEhzhBlA1tNKLeNa+EFifVSCgQcIybGwYuZzfptDK 7SSA== X-Gm-Message-State: ALoCoQmUDxERNS/2SZIkz6bJLm13SbajA0Ic1pL5oJ3DTZT12MnXlZJ+JDenBsbNsdgKdPZYHHBU X-Received: by 10.68.239.71 with SMTP id vq7mr1347441pbc.155.1415941976513; Thu, 13 Nov 2014 21:12:56 -0800 (PST) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id qm3sm26310325pdb.51.2014.11.13.21.12.54 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 13 Nov 2014 21:12:56 -0800 (PST) Message-ID: <54658F55.4070409@igel.co.jp> Date: Fri, 14 Nov 2014 14:12:53 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Linhaifeng , "Xie, Huawei" References: <5462DE39.1070006@igel.co.jp> <54645007.3010301@huawei.com> <54656950.1050204@igel.co.jp> <54657365.7090504@huawei.com> <546579A3.3010804@igel.co.jp> <54658853.2090100@huawei.com> In-Reply-To: <54658853.2090100@huawei.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] vhost-user technical isssues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Nov 2014 05:02:58 -0000 Hi Lin, (2014/11/14 13:42), Linhaifeng wrote: > > On 2014/11/14 11:40, Tetsuya Mukawa wrote: >> Hi Lin, >> >> (2014/11/14 12:13), Linhaifeng wrote: >>> size should be same as mmap and >>> guest_mem -= (memory.regions[i].mmap_offset / sizeof(*guest_mem)); >>> >> Thanks. It should be. >> How about following patch? >> >> ------------------------------------------------------- >> diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c >> index 75fedf0..be4b171 100644 >> --- a/tests/vhost-user-test.c >> +++ b/tests/vhost-user-test.c >> @@ -37,7 +37,7 @@ >> #endif >> >> #define QEMU_CMD_ACCEL " -machine accel=tcg" >> -#define QEMU_CMD_MEM " -m 512 -object >> memory-backend-file,id=mem,size=512M,"\ >> +#define QEMU_CMD_MEM " -m 6000 -object >> memory-backend-file,id=mem,size=6000M,"\ >> "mem-path=%s,share=on -numa node,memdev=mem" >> #define QEMU_CMD_CHR " -chardev socket,id=chr0,path=%s" >> #define QEMU_CMD_NETDEV " -netdev >> vhost-user,id=net0,chardev=chr0,vhostforce" >> @@ -221,13 +221,16 @@ static void read_guest_mem(void) >> >> /* check for sanity */ >> g_assert_cmpint(fds_num, >, 0); >> - g_assert_cmpint(fds_num, ==, memory.nregions); >> + //g_assert_cmpint(fds_num, ==, memory.nregions); >> >> + fprintf(stderr, "%s(%d)\n", __func__, __LINE__); >> /* iterate all regions */ >> for (i = 0; i < fds_num; i++) { >> + int ret = 0; >> >> /* We'll check only the region statring at 0x0*/ >> - if (memory.regions[i].guest_phys_addr != 0x0) { >> + if (memory.regions[i].guest_phys_addr == 0x0) { >> + close(fds[i]); >> continue; >> } >> >> @@ -237,6 +240,7 @@ static void read_guest_mem(void) >> >> guest_mem = mmap(0, size, PROT_READ | PROT_WRITE, > > How many is size? mmap_size + mmap_offset ? In this case, guest memory length is the size. I added messages from this program within last email. Could you please also check it? > > >> MAP_SHARED, fds[i], 0); >> + fprintf(stderr, "region=%d, mmap=%p, size=%lu\n", i, guest_mem, size); >> >> g_assert(guest_mem != MAP_FAILED); >> guest_mem += (memory.regions[i].mmap_offset / sizeof(*guest_mem)); >> @@ -247,8 +251,10 @@ static void read_guest_mem(void) >> >> g_assert_cmpint(a, ==, b); >> } >> - >> - munmap(guest_mem, memory.regions[i].memory_size); >> + guest_mem -= (memory.regions[i].mmap_offset / sizeof(*guest_mem)); >> + ret = munmap(guest_mem, memory.regions[i].memory_size); > memory.regions[i].memory_size --> memory.regions[i].memory_size + memory.regions[i].memory_offset > > check you have apply qemu's patch: [PATCH] vhost-user: fix mmap offset calculation I checked it using latest QEMU code. So the patch you mentioned is included. I guess you can munmap a file, because 'size' is aligned by hugepage size like 2GB. Could you please try another value like 6000MB? Thanks, Tetsuya