From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nicolas.pernas.maradei@emutex.com>
Received: from smtp.digiweb.ie (smtp2.digiweb.ie [83.147.160.14])
 by dpdk.org (Postfix) with ESMTP id 462CE3975
 for <dev@dpdk.org>; Mon, 17 Nov 2014 17:30:04 +0100 (CET)
Received: from statler.emutex.com (unknown [92.51.199.138])
 by smtp.digiweb.ie (Postfix) with ESMTP id 7CA84290001;
 Mon, 17 Nov 2014 16:40:20 +0000 (GMT)
Received: from [10.10.64.102]
 by statler.emutex.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
 (Exim 4.72) (envelope-from <nicolas.pernas.maradei@emutex.com>)
 id 1XqPLg-0004ys-7g; Mon, 17 Nov 2014 16:40:20 +0000
Message-ID: <546A24F3.4080107@emutex.com>
Date: Mon, 17 Nov 2014 16:40:19 +0000
From: Nicolas Pernas Maradei <nicolas.pernas.maradei@emutex.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:24.0) Gecko/20100101 Thunderbird/24.4.0
MIME-Version: 1.0
To: Neil Horman <nhorman@tuxdriver.com>, 
 Nicolas Pernas Maradei <nico@emutex.com>
References: <1416173215-27533-1-git-send-email-nicolas.pernas.maradei@emutex.com>
 <20141117141050.GD17886@hmsreliant.think-freely.org>
 <546A0BA2.3040306@emutex.com>
 <20141117160041.GF17886@hmsreliant.think-freely.org>
In-Reply-To: <20141117160041.GF17886@hmsreliant.think-freely.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: allow virtual devices to be white/black
 listed
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Nov 2014 16:30:04 -0000


On 17/11/14 16:00, Neil Horman wrote:
> I get that, I was more asking, why those values?  They seem a bit magic to me,
> and might benefit from some descriptive macros or comments so they make more
> sense
> Neil
OK, I get you now.

Maybe the diff is not very clear. I just left the original calls to 
rte_eal_devargs_add() with the original values which they looked clear 
to me but I don't mind improving the comments a bit and as you 
suggested, adding in some macros.

I'll wait for some more feedback before submitting a second version of 
the patch.

Thanks,
Nico.