Re: [dpdk-dev] [PATCH v2 09/13] mbuf: introduce new checksum API

[Olivier MATZ <olivier.matz@6wind.com>]

Hi Konstantin,

On 11/17/2014 07:15 PM, Ananyev, Konstantin wrote:
> Just 2 nits from me:
>
> 1)
>> +static inline uint16_t
>> +rte_raw_cksum(const char *buf, size_t len)
>> +{
> ...
>> +	while (len >= 8) {
>> +		sum += u16[0]; sum += u16[1]; sum += u16[2]; sum += u16[3];
>
> Can you put each expression into a new line?
> sum += u16[0];
> sum += u16[1];
> ...
>
> To make it easier to read.
> Or can it be rewritten just like:
> sum = (uint32_t)u16[0] + u16[1] + u16[2] + u16[3];
> here?
>
> 2)
>> +	while (len >= 8) {
>> +		sum += u16[0]; sum += u16[1]; sum += u16[2]; sum += u16[3];
>> +		len -= 8;
>> +		u16 += 4;
>> +	}
>> +	while (len >= 2) {
>> +		sum += *u16;
>> +		len -= 2;
>> +		u16 += 1;
>> +	}
>
> In the code above, probably use sizeof(u16[0]) wherever appropriate.
> To make things a bit more clearer and consistent.
> ...
> while (len >=  4 * sizeof(u16[0]))
> len -= 4 * sizeof(u16[0]);
> u16 += 4;
> ...
> Same for second loop

OK, I push that in the todo list for the v3.

Thanks,
Olivier