From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com [74.125.82.53])
 by dpdk.org (Postfix) with ESMTP id 61547592C
 for <dev@dpdk.org>; Tue, 18 Nov 2014 10:01:30 +0100 (CET)
Received: by mail-wg0-f53.google.com with SMTP id l18so3411775wgh.40
 for <dev@dpdk.org>; Tue, 18 Nov 2014 01:11:50 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
 :cc:subject:references:in-reply-to:content-type
 :content-transfer-encoding;
 bh=eJe1xooSKR6PFBbkNQekGHALCqE/gTdViDo0JIYOg74=;
 b=TZoG4kcZCNszL+iiuynfXGcla7p9rhdLtpyarHD2tGKtmSdf6wP4WBdarqF6nXgqqR
 OqV0dvg4eKKq/7ZOmy5G1ZzBnz9UNQgMOwQeMMq7QNspq5wEvS0H1LKl7Ape9MhjPWZR
 7KFDzXJp8xYVbaHjXBBG1gfhs90RO+ZS5K0BI+4ZO4JJ1wFt63SVeAuINVFX16K0itlP
 zGL4VUO+BEmQBNFMJk+5tw1Cpaac4DCCFGHllVOsghcJjDVnmA65yBv36h5jpYtXQ672
 Q6s0cF3rkOfNDJNXiwkug9JKMLd9GXjFOc/GnhSeX4+1eQnr5HFc1EU6xxe/3y5M6pEc
 g5mQ==
X-Gm-Message-State: ALoCoQm7m6kfW4sGzW48Y5nlMsbhX+57pkzF0qR+3J+2uJooqHFl3TguXOMnm9KxZxlVbCMN0C7v
X-Received: by 10.180.91.49 with SMTP id cb17mr2154455wib.30.1416301910728;
 Tue, 18 Nov 2014 01:11:50 -0800 (PST)
Received: from [10.16.0.195] (guy78-3-82-239-227-177.fbx.proxad.net.
 [82.239.227.177])
 by mx.google.com with ESMTPSA id cz3sm54958127wjb.23.2014.11.18.01.11.49
 for <multiple recipients>
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Tue, 18 Nov 2014 01:11:50 -0800 (PST)
Message-ID: <546B0D55.8020602@6wind.com>
Date: Tue, 18 Nov 2014 10:11:49 +0100
From: Olivier MATZ <olivier.matz@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:24.0) Gecko/20100101 Icedove/24.5.0
MIME-Version: 1.0
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, 
 "dev@dpdk.org" <dev@dpdk.org>
References: <1415635166-1364-1-git-send-email-olivier.matz@6wind.com>
 <1415984609-2484-1-git-send-email-olivier.matz@6wind.com>
 <1415984609-2484-12-git-send-email-olivier.matz@6wind.com>
 <2601191342CEEE43887BDE71AB977258213AE582@IRSMSX105.ger.corp.intel.com>
In-Reply-To: <2601191342CEEE43887BDE71AB977258213AE582@IRSMSX105.ger.corp.intel.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "jigsaw@gmail.com" <jigsaw@gmail.com>
Subject: Re: [dpdk-dev] [PATCH v2 11/13] ixgbe: support TCP segmentation
	offload
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Nov 2014 09:01:30 -0000

Hi Konstantin,

On 11/17/2014 07:26 PM, Ananyev, Konstantin wrote:
> Just one thing - double semicolon -  looks like a typo:
>> +	/* check if TCP segmentation required for this packet */
>> +	if (ol_flags & PKT_TX_TCP_SEG) {
>> +		/* implies IP cksum and TCP cksum */
>> +		type_tucmd_mlhl = IXGBE_ADVTXD_TUCMD_IPV4 |
>> +			IXGBE_ADVTXD_TUCMD_L4T_TCP |
>> +			IXGBE_ADVTXD_DTYP_CTXT | IXGBE_ADVTXD_DCMD_DEXT;;

Good catch, I'll fix this too.


Olivier