From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgw.gov.kz (mgw.gov.kz [89.218.88.242]) by dpdk.org (Postfix) with ESMTP id C5E2E595B for ; Tue, 18 Nov 2014 14:27:30 +0100 (CET) Received: from mgw.gov.kz (mx.ctsat.kz [178.89.4.95]) by mgw.gov.kz with ESMTP id sAIDbo9b012298-sAIDbo9d012298 (version=TLSv1.0 cipher=AES128-SHA bits=128 verify=NO); Tue, 18 Nov 2014 19:37:50 +0600 Received: from EXCASHUB1.rgp.local (192.168.40.51) by EdgeForefront.rgp.local (192.168.40.59) with Microsoft SMTP Server (TLS) id 14.2.247.3; Tue, 18 Nov 2014 19:37:38 +0600 Received: from [192.168.35.15] (192.168.35.15) by excashub1.rgp.local (192.168.40.48) with Microsoft SMTP Server (TLS) id 14.2.247.3; Tue, 18 Nov 2014 19:37:50 +0600 Message-ID: <546B4B83.4070103@sts.kz> Date: Tue, 18 Nov 2014 19:37:07 +0600 From: Yerden Zhumabekov User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Neil Horman , "dev@dpdk.org" References: <1416160760-16087-1-git-send-email-e_zhumabekov@sts.kz> <546AD178.9070109@sts.kz> <20141118133307.GA32375@hmsreliant.think-freely.org> In-Reply-To: <20141118133307.GA32375@hmsreliant.think-freely.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.35.15] X-FEAS-SYSTEM-WL: e_zhumabekov@sts.kz Subject: Re: [dpdk-dev] [PATCH v3 3/5] hash: add fallback to software CRC32 implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Nov 2014 13:27:31 -0000 18.11.2014 19:33, Neil Horman пишет: > On Tue, Nov 18, 2014 at 10:56:24AM +0600, Yerden Zhumabekov wrote: >> Sorry, maybe I made a mistake here. >> >> Accoring to lib/librte_eal/common/eal_common_cpuflags.c code, it seemed >> to me that constructor attribute is not supported by intel compiler. So >> in that case here I decided to leave the code for autodetection. Am I >> correct? >> > I don't think thats correct. The Intel Compiler claims support for most GCC > features, except where explicitly stated in the release notes, and I don't find > any documentation clearly excepting the constructor attribute from that list. > That said, since the intel compiler isn't open, I don't have access to it and > cannot confirm either way, though if its the case, the DPDK has a major issue, > as __attribute__((constructor)) is used extensively throughout the code > Neil My bad. Ok, I'll redo it again and send the series as 'v4'. Thanks. -- Sincerely, Yerden Zhumabekov State Technical Service Astana, KZ