From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com
 [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 6C9305323
 for <dev@dpdk.org>; Tue, 18 Nov 2014 15:00:26 +0100 (CET)
Received: by mail-wi0-f182.google.com with SMTP id h11so12721588wiw.15
 for <dev@dpdk.org>; Tue, 18 Nov 2014 06:10:47 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
 :cc:subject:references:in-reply-to:content-type
 :content-transfer-encoding;
 bh=wPVhoOPUPaerOy55/iFQ/xmw172sQSKQhC+yFkKcEZg=;
 b=fPBTOQqpe9heOEYwtLFbods/YwMFiv/3yYMkRdoxMaAVbn3UfRssnt0nztpUJhGIz5
 b+rOoNXH8LdRxATWItd/QUkbV80WAHnvjfZ9/MEE8rXF3oJaWxSMlr+0RFCaxCBuoD1r
 0OwxFl3x9WIbPGnxJRRWbypneCW4JK7iGvB8jDR4qny1VxboyQdsWgTS6MU4pdWrvkym
 l47TPn87z+nWiXK+YqgQwguw9SlS1XWr5fDtJmLHzTDDFBUuZxBwobEvtRZ/W7a8vOuB
 ROjRgpF1KJ0vFuRy9IbSH8y12oDvqF6wrIG5Y3hflEV4Hd/iqCcRH29xgAbPsMe/wy7S
 wOrg==
X-Gm-Message-State: ALoCoQkgEiuuM8GfGTdQASUKc6D7++xGkXBmnN06kSSLgGCzNbkYVNMojIMJ9gH4OsWzmP0WsRmY
X-Received: by 10.180.93.132 with SMTP id cu4mr4222943wib.46.1416319847676;
 Tue, 18 Nov 2014 06:10:47 -0800 (PST)
Received: from [10.16.0.195] (guy78-3-82-239-227-177.fbx.proxad.net.
 [82.239.227.177])
 by mx.google.com with ESMTPSA id dx8sm19714154wib.2.2014.11.18.06.10.47
 for <multiple recipients>
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Tue, 18 Nov 2014 06:10:47 -0800 (PST)
Message-ID: <546B5366.1050907@6wind.com>
Date: Tue, 18 Nov 2014 15:10:46 +0100
From: Olivier MATZ <olivier.matz@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:24.0) Gecko/20100101 Icedove/24.5.0
MIME-Version: 1.0
To: Thomas Monjalon <thomas.monjalon@6wind.com>
References: <1415635166-1364-1-git-send-email-olivier.matz@6wind.com>
 <1415984609-2484-1-git-send-email-olivier.matz@6wind.com>
 <1415984609-2484-4-git-send-email-olivier.matz@6wind.com>
 <2131099.vnRQzAWZnp@xps13>
In-Reply-To: <2131099.vnRQzAWZnp@xps13>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 03/13] mbuf: move vxlan_cksum flag
 definition at the proper place
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Nov 2014 14:00:26 -0000

Hi Thomas,

On 11/17/2014 11:05 PM, Thomas Monjalon wrote:
> 2014-11-14 18:03, Olivier Matz:
>> The tx mbuf flags are ordered from the highest value to the
>> the lowest. Move the PKT_TX_VXLAN_CKSUM at the right place.
>
> Please, could you reorder them from the lowest to the highest?
> It will be simpler to understand. There is already a comment to explain
> the reverse allocation of Tx flags.
>
> Thanks

Sure, I'll do that in a separate commit.

Olivier