From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgw.gov.kz (mgw.gov.kz [89.218.88.242]) by dpdk.org (Postfix) with ESMTP id 6F31E7EB0 for ; Tue, 18 Nov 2014 18:49:20 +0100 (CET) Received: from mgw.gov.kz (mx.ctsat.kz [178.89.4.95]) by mgw.gov.kz with ESMTP id sAIHxfUK023687-sAIHxfUM023687 (version=TLSv1.0 cipher=AES128-SHA bits=128 verify=NO); Tue, 18 Nov 2014 23:59:41 +0600 Received: from EXCASHUB1.rgp.local (192.168.40.51) by EdgeForefront.rgp.local (192.168.40.59) with Microsoft SMTP Server (TLS) id 14.2.247.3; Tue, 18 Nov 2014 23:59:30 +0600 Received: from [192.168.35.15] (192.168.35.15) by excashub1.rgp.local (192.168.40.48) with Microsoft SMTP Server (TLS) id 14.2.247.3; Tue, 18 Nov 2014 23:59:34 +0600 Message-ID: <546B88DB.3010207@sts.kz> Date: Tue, 18 Nov 2014 23:58:51 +0600 From: Yerden Zhumabekov User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Neil Horman References: <1409724351-23786-1-git-send-email-e_zhumabekov@sts.kz> <20141118144138.GB32375@hmsreliant.think-freely.org> <546B607B.9030808@sts.kz> <20141118160005.GC32375@hmsreliant.think-freely.org> <546B7E2D.7050705@sts.kz> <20141118174619.GE32375@hmsreliant.think-freely.org> In-Reply-To: <20141118174619.GE32375@hmsreliant.think-freely.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [192.168.35.15] X-FEAS-SYSTEM-WL: e_zhumabekov@sts.kz Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v4 3/5] hash: add fallback to software CRC32 implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Nov 2014 17:49:20 -0000 18.11.2014 23:46, Neil Horman =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > On Tue, Nov 18, 2014 at 11:13:17PM +0600, Yerden Zhumabekov wrote: >> 18.11.2014 22:00, Neil Horman =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>> >>> You need to edit the makefile so that the compiler gets passed the op= tion >>> -msse42. That way it will know to emit sse42 instructions. It will a= lso allow >>> you to remove the ifdef from the include file >> In this case, I guess there are two options: >> 1) modify all makefiles which use librte_hash >> 2) move all function bodies from rte_hash_crc.h to separate module, >> leaving prototype definitions there only. >> >> Everybody's up for the second option? :) >> > Crud, you're right, I didn't think about the header inclusion issue. I= s it > worth adding the jump to enable the dynamic hash selection? If I understood you correctly - I've already added a function to dynamically change the CRC32 implementation in the runtime, rte_hash_crc_set_alg(). I can rework patches once again, if everybody's fine with the separate module. --=20 Sincerely, Yerden Zhumabekov State Technical Service Astana, KZ