From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 74E816CB1 for ; Mon, 20 Jun 2016 11:45:36 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id a66so70299220wme.0 for ; Mon, 20 Jun 2016 02:45:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=zmshZv8rQqR+F89OC0olZlI/Jecd8N8mSbYPRKxxnbw=; b=tq1ZNhSOd3r5Z2L7rELaLKEE6SDgIugZJq3qGe3t+fio03Qvtnhs2fmGnWcu8g3Gqd 7rbtf5s7nF73XtqqtRUcJb39ytBRWq/iboZGvB+i8fg0wrTxZ/Fhyyx7Y1din/M7KJr5 Ob6EHNddbO0IkSEll0eAe3rHUuoe6Yya9PpETcVuz6lE0TuIpwHAfmnWXgn6p9TCC/R8 0Q2FgVF5bj/CL54wJivu4f6acugFVGyBhC+XxMYShwCPBEATkJzDT6b7k4ixen2RYLZH BChc2QGD5cU/8IM88IHSDz3s5HVl0HQcz5c9UfgQQfefHIrweNwH+Zvuan9wjEfdWx4c ZmRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=zmshZv8rQqR+F89OC0olZlI/Jecd8N8mSbYPRKxxnbw=; b=AB4M83XUP6i1c0DqJlINlO8loFszKgUeTGxXPGNp+lB4shH7iKsQLwyBFG/puJo79J bMJKOQdRmRwBgnvKiFusTGdxAhL2h1UtuihQa2rjNQvXng3ow9accNoZr8jHIc9+ScwJ Arj+QmC/1o3bSGzd5BhC78NUuGHwyBcNu18fO5SEw3tctFJ+nm51r6UEOog7dWh6LfPd tPv9Cq6Ql3RSGuX355OjBdejNleiJD0JVWsi6ZDGsRR3XaPBWK6TwuWhy+PCzi0mtOYn zvym9QJ5IIUwlYLRGsQ+TqdL9MeSHsDV+DrNQd+4W0671lQEdQqo8keQCruOv/L6GKxI 4gPA== X-Gm-Message-State: ALyK8tKTS/KPThVHHpHpARcH4naQDq1TVVetJUuc//zC7eZ9XacsExrG6RHYLhzIKGTKEJ5o X-Received: by 10.194.136.72 with SMTP id py8mr13494182wjb.126.1466415936236; Mon, 20 Jun 2016 02:45:36 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id v70sm2337469wmf.18.2016.06.20.02.45.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Jun 2016 02:45:34 -0700 (PDT) From: Thomas Monjalon To: "Jain, Deepak K" , declan.doherty@intel.com Cc: dev@dpdk.org, john.griffin@intel.com, fiona.trahe@intel.com, pablo.de.lara.guarch@intel.com Date: Mon, 20 Jun 2016 11:45:33 +0200 Message-ID: <5472998.Ej0WxNay6E@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1466106543-209204-2-git-send-email-deepak.k.jain@intel.com> References: <1466106543-209204-1-git-send-email-deepak.k.jain@intel.com> <1466106543-209204-2-git-send-email-deepak.k.jain@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/4] cryptodev: add rte_crypto_op_bulk_free function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2016 09:45:36 -0000 2016-06-16 20:49, Jain, Deepak K: > From: Declan Doherty > > Adding rte_crypto_op_bulk_free to free up the ops in bulk > so as to expect improvement in performance. > > Signed-off-by: Declan Doherty I wonder why these changes are dropped so late? > /** > + * free crypto operation structure > + * If operation has been allocate from a rte_mempool, then the operation will > + * be returned to the mempool. > + * > + * @param op symmetric crypto operation > + */ Please check punctuation, grammar and document every parameters. > +static inline void > +rte_crypto_op_bulk_free(struct rte_mempool *mpool, struct rte_crypto_op **ops, > + uint16_t nb_ops)