Re: [dpdk-dev] [PATCH v3] config: remove duplicate configuration information

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2016-03-06 01:11, Ferruh Yigit:
> On 3/4/2016 10:43 PM, Thomas Monjalon wrote:
> > 2016-03-04 12:11, Keith Wiles:
> >> In order to cleanup the configuration files some and reduce
> >> the number of duplicate configuration information. Add a new
> >> file called common_base which contains just about all of the
> >> configuration lines in one place. Then have the common_bsdapp,
> >> common_linuxapp files include this one file. Then in those OS
> >> specific files add the delta configuration lines.
> >>
> >> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
> > 
> > It's also fixing the crypto settings which were mispelled for BSD.
> > 
> > Applied with few cosmetic adjustments, thanks.
> > 
> This is already applied, but,
> 
> Is it required to keep Linux specific features
> (igb_uio/vfio/kni/vhost..) in base config? Why not move all to Linux
> only config?

I have no strong opinion.
Keeping them in the base file makes easy to list every options.
On the other hand, we already have MPIPE defined only in tilegx config
and CONTIGEM only in bsdapp.

> Because they show up in final bsd config, which is unnecessary. Also
> they show up in final Linux config twice, first one disables feature and
> second one enables back. Although this works fine both for bsd and
> Linux, it is confusing.