From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 779C92C50 for ; Sun, 6 Mar 2016 10:37:28 +0100 (CET) Received: by mail-wm0-f50.google.com with SMTP id p65so38423540wmp.0 for ; Sun, 06 Mar 2016 01:37:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=rSYC6M90ahfobUm+iw7kcWyP57Pk1btIE+7PaYJkyKw=; b=ccp2DbBi9eDT2eFW088x2c0yPuDi6WfP5MVQpG3d1RVM7GJwchAgqVt8WU48R+R4qE LqDauvUJTS993EmFs09VVPe/UZxmm6eWtjmGKc6vDV95Qr6ReYqKzqkBCepRcTlNdkjH cf46DWNFJvOJfqYP0oFSwa9siQlEVZI3c1XtVac79sBrGg0bs0RjKBYMBg1MGlNlJG78 FCKRn7Qf9obusX0zVwz64bdoxOup8UHDGJ40tCLrhoVkFadDn0gd/WLNSdF8zfCewD3g u3UgUMDqZhw5e72a9VV9hWKBDxXVaEnk6WhUNKbljMOVsTIFAiaQyTf82CqkrTjMy04N FZ5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=rSYC6M90ahfobUm+iw7kcWyP57Pk1btIE+7PaYJkyKw=; b=IdK4ao9kIkbVa9ylQZrxB+iSPHRuzou6WVPEbSyBJi7Jzw4U9EjEtkpU4mwQKTL7ou rc4V/GoAeQpkkctwsxWiK2h15azsgTxvvqpotm0WHx3JzuVd9F7EOlv5Sap71uUa+UEf +dAB1Y6aFItmVm26P5BSj7CgaYpulmhCgY+bjfQK0FLMocLvlK9Hm2KJU91LffMQ1MLi enxpZGGW+ke5bnZ/F79VLIRwURP/JAc2VApRPWNctgS+fP+REcbBI43eT39+rWXBCKnT F7KuFqFYvfTrZZcYJbUJeHOdE+qatj7R6bJeEuUowZL2tDXWdTYC2LZtCyW4MD349bBK wZpg== X-Gm-Message-State: AD7BkJINCFUdwD/MosAUw5jUl7I9Z9mYuyZU1PCpO0Kt8y4Hsb/okyokI4j4mzA/cloRc40z X-Received: by 10.194.24.39 with SMTP id r7mr16206422wjf.86.1457257048293; Sun, 06 Mar 2016 01:37:28 -0800 (PST) Received: from xps13.localnet (171.36.101.84.rev.sfr.net. [84.101.36.171]) by smtp.gmail.com with ESMTPSA id x186sm7768792wmg.19.2016.03.06.01.37.26 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 06 Mar 2016 01:37:27 -0800 (PST) From: Thomas Monjalon To: Ferruh Yigit Date: Sun, 06 Mar 2016 10:35:50 +0100 Message-ID: <5474006.zCJzWiptFr@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <56DB83D9.3030009@intel.com> References: <121442835.2vdhmXQbJs@xps13> <1982157.64YrbiQtVx@xps13> <56DB83D9.3030009@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3] config: remove duplicate configuration information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Mar 2016 09:37:28 -0000 2016-03-06 01:11, Ferruh Yigit: > On 3/4/2016 10:43 PM, Thomas Monjalon wrote: > > 2016-03-04 12:11, Keith Wiles: > >> In order to cleanup the configuration files some and reduce > >> the number of duplicate configuration information. Add a new > >> file called common_base which contains just about all of the > >> configuration lines in one place. Then have the common_bsdapp, > >> common_linuxapp files include this one file. Then in those OS > >> specific files add the delta configuration lines. > >> > >> Signed-off-by: Keith Wiles > > > > It's also fixing the crypto settings which were mispelled for BSD. > > > > Applied with few cosmetic adjustments, thanks. > > > This is already applied, but, > > Is it required to keep Linux specific features > (igb_uio/vfio/kni/vhost..) in base config? Why not move all to Linux > only config? I have no strong opinion. Keeping them in the base file makes easy to list every options. On the other hand, we already have MPIPE defined only in tilegx config and CONTIGEM only in bsdapp. > Because they show up in final bsd config, which is unnecessary. Also > they show up in final Linux config twice, first one disables feature and > second one enables back. Although this works fine both for bsd and > Linux, it is confusing.