From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e23smtp08.au.ibm.com (e23smtp08.au.ibm.com [202.81.31.141]) by dpdk.org (Postfix) with ESMTP id C42D45323 for ; Tue, 25 Nov 2014 10:08:33 +0100 (CET) Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 25 Nov 2014 19:19:23 +1000 Received: from d23dlp01.au.ibm.com (202.81.31.203) by e23smtp08.au.ibm.com (202.81.31.205) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 25 Nov 2014 19:19:21 +1000 Received: from d23relay09.au.ibm.com (d23relay09.au.ibm.com [9.185.63.181]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id E414C2CE8055 for ; Tue, 25 Nov 2014 20:19:17 +1100 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay09.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id sAP9JHhl34406512 for ; Tue, 25 Nov 2014 20:19:17 +1100 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id sAP9JHFw006039 for ; Tue, 25 Nov 2014 20:19:17 +1100 Received: from [127.0.0.1] ([9.186.104.132]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id sAP9JEO4005984; Tue, 25 Nov 2014 20:19:16 +1100 Message-ID: <547449BC.5080206@linux.vnet.ibm.com> Date: Tue, 25 Nov 2014 17:19:56 +0800 From: Chao Zhu User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Bruce Richardson References: <1416792142-23132-1-git-send-email-chaozhu@linux.vnet.ibm.com> <1416792142-23132-2-git-send-email-chaozhu@linux.vnet.ibm.com> <20141123220246.GA27315@hmsreliant.think-freely.org> <5473FCB1.9080507@linux.vnet.ibm.com> <20141125084439.GA6696@bricha3-MOBL3> In-Reply-To: <20141125084439.GA6696@bricha3-MOBL3> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14112509-0029-0000-0000-000000ABBC71 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 01/14] Add compiling definations for IBM Power architecture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Nov 2014 09:08:35 -0000 Bruce, Good point! I'll update the current patches. Thanks for your suggestions! On 2014/11/25 16:44, Bruce Richardson wrote: > On Tue, Nov 25, 2014 at 11:51:13AM +0800, Chao Zhu wrote: >> Neil, >> Current Power related patches are not a full functional one. Some of the >> libraries are not migrated. So >> common_linuxapp_powerpc is used to turn off the uncompiled part. > Hi Chao, > just to re-echo what Neil says - this would be better as a > defconfig_powerpc-native-linuxapp-gcc config file including common_linuxapp. > Anything you need to turn off in the config can be turned off in the defconfig > file after you include the common_linuxapp one - later definitions override > earlier ones. It also makes things clearer to read as you end up with a > powerpc config file that essentially reads as "use common linux settings except > for this, and this, and this, etc...." > > Regards, > /Bruce > >> This file >> is a copy of the common_linuxapp. And this file is intended to be removed >> when all of the libraries are migrated to Power. Actually, it's the current >> common file for linux and other OS, such as BSD. However, I didn't try the >> compilation on BSD. But this probably needs to be done. >> >> On 2014/11/24 6:02, Neil Horman wrote: >>> On Sun, Nov 23, 2014 at 08:22:09PM -0500, Chao Zhu wrote: >>>> To make DPDK run on IBM Power architecture, configuration files for >>>> Power architecuture are added. Also, the compiling related .mk files are >>>> added. >>>> >>>> Signed-off-by: Chao Zhu >>>> --- >>>> config/common_linuxapp_powerpc | 394 +++++++++++++++++++++++++++ >>>> config/defconfig_ppc_64-power8-linuxapp-gcc | 40 +++ >>>> mk/arch/ppc_64/rte.vars.mk | 39 +++ >>>> mk/machine/power8/rte.vars.mk | 57 ++++ >>>> 4 files changed, 530 insertions(+), 0 deletions(-) >>>> create mode 100644 config/common_linuxapp_powerpc >>>> create mode 100644 config/defconfig_ppc_64-power8-linuxapp-gcc >>>> create mode 100644 mk/arch/ppc_64/rte.vars.mk >>>> create mode 100644 mk/machine/power8/rte.vars.mk >>>> >>>> diff --git a/config/common_linuxapp_powerpc b/config/common_linuxapp_powerpc >>>> new file mode 100644 >>>> index 0000000..d230a0b >>>> --- /dev/null >>>> +++ b/config/common_linuxapp_powerpc >>> This filename is common_linuxapp_powerpc, but given that it explicitly specifies >>> all the build options, there isn't really anything common about it. I think >>> what you want to do is rename this defconfig_powerpc-native-linuxapp-gcc, and >>> have it include common_linuxapp, then change any power-specific option you see >>> fit. >>> >>> Also, does BSD build on power? I presume so. You likely want to create a >>> corresponding bsd power config >>> >>