From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id BD8CB231C for ; Thu, 27 Nov 2014 11:00:07 +0100 (CET) Received: by mail-wi0-f182.google.com with SMTP id h11so7711613wiw.9 for ; Thu, 27 Nov 2014 02:00:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=oh3L7+V6eUkvw/+D63fT0XYatez7PBej9vK+iqEfBeM=; b=FGKSLOwK2zJyPlPsaQeUVM3dv0NnBIh5fqyzvk6l/B1a0lq0NNH0337xuivhqq6aav 0FVjNLLWOprUZI3EhFPxO0oVJzg9dnxxqd8cp0EaA28yBhzjwgmFcRxU4Nk7eTNkBOAp 6EU5NzaOcPwJyrtwVPJQS8UBR1OCL7eV1V0r+GQ+cgu8GIKWjcV2PZnXvEkDA5jUZOuf tnsQqU3+HfYST+N3xlwGS672pZG8dDzbmx+reJ8uj7uUjlgtmbKmfWbsw+4DYv/G89iA b77iWTRhsaFOa/uZTQuABQN7fEEH83Mb2+Oo6wB6eG2igxQXbQgLULQKiNMtmnePyWti Izvw== X-Gm-Message-State: ALoCoQmo26bFrfvvAiso9dHasrnKnorO0roNOzNfmY88veKwX3h8QInBKwm+K1F20vLFfethDOXf X-Received: by 10.180.81.70 with SMTP id y6mr50723328wix.6.1417082407545; Thu, 27 Nov 2014 02:00:07 -0800 (PST) Received: from [10.16.0.195] (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id fg2sm5073400wib.2.2014.11.27.02.00.06 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 27 Nov 2014 02:00:07 -0800 (PST) Message-ID: <5476F626.2020708@6wind.com> Date: Thu, 27 Nov 2014 11:00:06 +0100 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 MIME-Version: 1.0 To: Jijiang Liu , dev@dpdk.org References: <1417076319-629-1-git-send-email-jijiang.liu@intel.com> <1417076319-629-2-git-send-email-jijiang.liu@intel.com> In-Reply-To: <1417076319-629-2-git-send-email-jijiang.liu@intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and change three fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Nov 2014 10:00:07 -0000 Hi Jijiang, Please see some comments below. On 11/27/2014 09:18 AM, Jijiang Liu wrote: > In place of removing the PKT_TX_VXLAN_CKSUM, we introduce 2 new flags: PKT_TX_OUT_IP_CKSUM, PKT_TX_UDP_TUNNEL_PKT, and a new field: l4_tun_len. > Replace the inner_l2_len and the inner_l3_len field with the outer_l2_len and outer_l3_len field. > > PKT_TX_OUT_IP_CKSUM: is not used for non-tunnelling packet;hardware outer checksum for tunnelling packet. > PKT_TX_UDP_TUNNEL_PKT: is used to tell PMD that the transmit packet is a UDP tunneling packet. > l4_tun_len: for VXLAN packet, it should be udp header length plus VXLAN header length. > > Signed-off-by: Jijiang Liu > --- > lib/librte_mbuf/rte_mbuf.c | 2 +- > lib/librte_mbuf/rte_mbuf.h | 23 ++++++++++++++--------- > 2 files changed, 15 insertions(+), 10 deletions(-) > > diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c > index 87c2963..e89c310 100644 > --- a/lib/librte_mbuf/rte_mbuf.c > +++ b/lib/librte_mbuf/rte_mbuf.c > @@ -240,7 +240,7 @@ const char *rte_get_tx_ol_flag_name(uint64_t mask) > case PKT_TX_SCTP_CKSUM: return "PKT_TX_SCTP_CKSUM"; > case PKT_TX_UDP_CKSUM: return "PKT_TX_UDP_CKSUM"; > case PKT_TX_IEEE1588_TMST: return "PKT_TX_IEEE1588_TMST"; > - case PKT_TX_VXLAN_CKSUM: return "PKT_TX_VXLAN_CKSUM"; > + case PKT_TX_UDP_TUNNEL_PKT: return "PKT_TX_UDP_TUNNEL_PKT"; > case PKT_TX_TCP_SEG: return "PKT_TX_TCP_SEG"; > default: return NULL; As I said as a reply to the cover letter, I suggest to use PKT_TX_OUT_UDP_CKSUM instead of PKT_TX_UDP_TUNNEL_PKT. Also, the PKT_TX_OUT_IP_CKSUM case is missing here. > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > index 367fc56..48cd8e1 100644 > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -99,10 +99,9 @@ extern "C" { > #define PKT_RX_TUNNEL_IPV6_HDR (1ULL << 12) /**< RX tunnel packet with IPv6 header. */ > #define PKT_RX_FDIR_ID (1ULL << 13) /**< FD id reported if FDIR match. */ > #define PKT_RX_FDIR_FLX (1ULL << 14) /**< Flexible bytes reported if FDIR match. */ > -/* add new RX flags here */ > We should probably not remove this line. > /* add new TX flags here */ > -#define PKT_TX_VXLAN_CKSUM (1ULL << 50) /**< TX checksum of VXLAN computed by NIC */ > +#define PKT_TX_UDP_TUNNEL_PKT (1ULL << 50) /**< TX packet is an UDP tunneling packet */ > #define PKT_TX_IEEE1588_TMST (1ULL << 51) /**< TX IEEE1588 packet to timestamp. */ > > /** > @@ -125,13 +124,20 @@ extern "C" { > #define PKT_TX_IP_CKSUM (1ULL << 54) /**< IP cksum of TX pkt. computed by NIC. */ > #define PKT_TX_IPV4_CSUM PKT_TX_IP_CKSUM /**< Alias of PKT_TX_IP_CKSUM. */ > > +#define PKT_TX_VLAN_PKT (1ULL << 55) /**< TX packet is a 802.1q VLAN packet. */ > + > /** Tell the NIC it's an IPv4 packet. Required for L4 checksum offload or TSO. */ > -#define PKT_TX_IPV4 PKT_RX_IPV4_HDR > +#define PKT_TX_IPV4 (1ULL << 56) > > /** Tell the NIC it's an IPv6 packet. Required for L4 checksum offload or TSO. */ > -#define PKT_TX_IPV6 PKT_RX_IPV6_HDR > +#define PKT_TX_IPV6 (1ULL << 57) The description in comment does not match the description in the cover letter. Also, I think replacing PKT_RX_IPV[46]_HDR by the value may go in another commit. > -#define PKT_TX_VLAN_PKT (1ULL << 55) /**< TX packet is a 802.1q VLAN packet. */ > +/** Outer IP cksum of TX pkt. computed by NIC for tunneling packet */ > +#define PKT_TX_OUTER_IP_CKSUM (1ULL << 58) > +#define PKT_TX_OUTER_IPV4_CSUM PKT_TX_OUTER_IP_CKSUM /**< Alias of PKT_TX_OUTER_IP_CKSUM. */ Why do we need an alias? By the way, I think the alias of PKT_TX_IP_CKSUM is also uneeded and can be removed. But it's not the topic of your series. Also, the name PKT_TX_OUTER_IP_CKSUM does not match the name in the cover letter and commit logs. > + > +/** Tell the NIC it's an outer IPv6 packet for tunneling packet.*/ > +#define PKT_TX_OUTER_IPV6 (1ULL << 59) > This flag is not in the cover letter or commit log. What is its purpose? > /** > * TCP segmentation offload. To enable this offload feature for a > @@ -266,10 +272,9 @@ struct rte_mbuf { > uint64_t tso_segsz:16; /**< TCP TSO segment size */ > > /* fields for TX offloading of tunnels */ > - uint64_t inner_l3_len:9; /**< inner L3 (IP) Hdr Length. */ > - uint64_t inner_l2_len:7; /**< inner L2 (MAC) Hdr Length. */ > - > - /* uint64_t unused:8; */ > + uint64_t outer_l3_len:9; /**< outer L3 (IP) Hdr Length. */ > + uint64_t outer_l2_len:7; /**< outer L2 (MAC) Hdr Length. */ > + uint64_t l4_tun_len:8; /**< L4 tunnelling header length */ > }; > }; > } __rte_cache_aligned; > About l4_tun_len, I have another comment I forgot to add in the cover letter. Can we remove it and include its length in outer_l2_len instead? For instance, replace: mb->l2_len = eth_hdr_in; mb->l3_len = ipv4_hdr_in; mb->outer_l2_len = eth_hdr_out; mb->outer_l3_len = ipv4_hdr_out; mb->l4tun_len = vxlan_hdr; mb->ol_flags |= PKT_TX_OUT_IP_CKSUM | PKT_TX_UDP_TUNNEL | PKT_TX_IP_CKSUM | PKT_TX_TCP_CKSUM; by: mb->l2_len = eth_hdr_in; mb->l3_len = ipv4_hdr_in; mb->outer_l2_len = eth_hdr_out + vxlan_hdr; mb->outer_l3_len = ipv4_hdr_out; mb->ol_flags |= PKT_TX_OUT_IP_CKSUM | PKT_TX_UDP_TUNNEL | PKT_TX_IP_CKSUM | PKT_TX_TCP_CKSUM; I think it won't bother the driver, and it's coherent with case B.2 of your cover letter. Regards, Olivier