From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 204D61518 for ; Fri, 28 Nov 2014 10:17:39 +0100 (CET) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XuHjL-0004g4-4l; Fri, 28 Nov 2014 10:20:50 +0100 Message-ID: <54783DA8.6000508@6wind.com> Date: Fri, 28 Nov 2014 10:17:28 +0100 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 MIME-Version: 1.0 To: "Liu, Jijiang" , "dev@dpdk.org" References: <1417076319-629-1-git-send-email-jijiang.liu@intel.com> <1417076319-629-2-git-send-email-jijiang.liu@intel.com> <5476F626.2020708@6wind.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC01D9EE79@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D9EE79@SHSMSX101.ccr.corp.intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and change three fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Nov 2014 09:17:39 -0000 Hi Jijiang, On 11/27/2014 02:14 PM, Liu, Jijiang wrote: >>> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h >>> index 367fc56..48cd8e1 100644 >>> --- a/lib/librte_mbuf/rte_mbuf.h >>> +++ b/lib/librte_mbuf/rte_mbuf.h >>> @@ -99,10 +99,9 @@ extern "C" { >>> #define PKT_RX_TUNNEL_IPV6_HDR (1ULL << 12) /**< RX tunnel packet with >> IPv6 header. */ >>> #define PKT_RX_FDIR_ID (1ULL << 13) /**< FD id reported if FDIR match. >> */ >>> #define PKT_RX_FDIR_FLX (1ULL << 14) /**< Flexible bytes reported if FDIR >> match. */ >>> -/* add new RX flags here */ >>> >> >> We should probably not remove this line. > > Why? > There are two lines "/* add new RX flags here */" in rte_mbuf.h file. No, one is RX, the other is TX. >>> +/** Tell the NIC it's an outer IPv6 packet for tunneling packet.*/ >>> +#define PKT_TX_OUTER_IPV6 (1ULL << 59) >>> >> >> This flag is not in the cover letter or commit log. What is its purpose? >> > With FVL, if outer L3 header is IPv6, to make HW TX checksum offload work , SW must be responsible to tell hardware this information. What hardware checksum are you talking about? I understand that outer L4 checksum is not supported from one of Konstantin's mail. And there is no L3 checksum in IPv6. Regards, Olivier