From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 4EEBD2A9
 for <dev@dpdk.org>; Fri, 28 Nov 2014 10:37:00 +0100 (CET)
Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214]
 helo=[192.168.0.10])
 by mail.droids-corp.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)
 (Exim 4.80) (envelope-from <olivier.matz@6wind.com>)
 id 1XuI24-0004gm-Py; Fri, 28 Nov 2014 10:40:11 +0100
Message-ID: <54784232.8030707@6wind.com>
Date: Fri, 28 Nov 2014 10:36:50 +0100
From: Olivier MATZ <olivier.matz@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:24.0) Gecko/20100101 Icedove/24.5.0
MIME-Version: 1.0
To: Jijiang Liu <jijiang.liu@intel.com>, dev@dpdk.org
References: <1417107801-9544-1-git-send-email-jijiang.liu@intel.com>
 <1417107801-9544-2-git-send-email-jijiang.liu@intel.com>
In-Reply-To: <1417107801-9544-2-git-send-email-jijiang.liu@intel.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v3 1/4] mbuf:add three TX offload flags and
 change three fields
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Nov 2014 09:37:00 -0000

Hi Jijiang,

On 11/27/2014 06:03 PM, Jijiang Liu wrote:
>  /** Tell the NIC it's an IPv4 packet. Required for L4 checksum offload or TSO. */
>  #define PKT_TX_IPV4          PKT_RX_IPV4_HDR
>  
>  /** Tell the NIC it's an IPv6 packet. Required for L4 checksum offload or TSO. */
>  #define PKT_TX_IPV6          PKT_RX_IPV6_HDR

The description still does not match what we discussed. Either we
have PKT_TX_IPV4 meaning "packet is IPv4 without requiring IP cksum
offload", or  "packet is IPv4". I prefer the second one, but whatever
the choice is, the comments must be coherent.

> -#define PKT_TX_VLAN_PKT      (1ULL << 55) /**< TX packet is a 802.1q VLAN packet. */
> +/** Outer IP cksum of TX pkt. computed by NIC for tunneling packet */
> +#define PKT_TX_OUTER_IP_CKSUM   (1ULL << 58)
> +
> +/** Tell the NIC it's an outer IPv6 packet for tunneling packet.*/
> +#define PKT_TX_OUTER_IPV6    (1ULL << 59)

I think we should have the same flags with the same meanings for
inner and outer:

- PKT_TX_IPV4, PKT_TX_IP_CKSUM, PKT_TX_IPV6
- PKT_TX_OUTER_IPV4, PKT_TX_OUTER_IP_CKSUM, PKT_TX_OUTER_IPV6

In your patch there is no PKT_TX_OUTER_IPV4 flag.

Regards,
Olivier