From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id B7AF52A9 for ; Fri, 28 Nov 2014 10:37:24 +0100 (CET) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XuI2T-0004gs-7F; Fri, 28 Nov 2014 10:40:37 +0100 Message-ID: <5478424A.8030008@6wind.com> Date: Fri, 28 Nov 2014 10:37:14 +0100 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 MIME-Version: 1.0 To: Jijiang Liu , dev@dpdk.org References: <1417107801-9544-1-git-send-email-jijiang.liu@intel.com> <1417107801-9544-3-git-send-email-jijiang.liu@intel.com> In-Reply-To: <1417107801-9544-3-git-send-email-jijiang.liu@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 2/4] mbuf:change PKT_TX_IPV4 and PKT_TX_IPV6 definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Nov 2014 09:37:24 -0000 On 11/27/2014 06:03 PM, Jijiang Liu wrote: > It will avoid to send a packet with a bad info: > - we receive a Ether/IP6/IP4/L4/data packet > - the driver sets PKT_RX_IPV6_HDR > - the stack decapsulates IP6 > - the stack sends the packet, it has the PKT_TX_IPV6 flag but it's an IPv4 packet. > > Signed-off-by: Jijiang Liu > --- > lib/librte_mbuf/rte_mbuf.h | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > index 22ee555..f6b3185 100644 > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -127,10 +127,10 @@ extern "C" { > #define PKT_TX_VLAN_PKT (1ULL << 55) /**< TX packet is a 802.1q VLAN packet. */ > > /** Tell the NIC it's an IPv4 packet. Required for L4 checksum offload or TSO. */ > -#define PKT_TX_IPV4 PKT_RX_IPV4_HDR > +#define PKT_TX_IPV4 (1ULL << 56) > > /** Tell the NIC it's an IPv6 packet. Required for L4 checksum offload or TSO. */ > -#define PKT_TX_IPV6 PKT_RX_IPV6_HDR > +#define PKT_TX_IPV6 (1ULL << 57) > > /** Outer IP cksum of TX pkt. computed by NIC for tunneling packet */ > #define PKT_TX_OUTER_IP_CKSUM (1ULL << 58) > Acked-by: Olivier Matz