Re: [dpdk-dev] [PATCH v3 4/4] testpmd:rework csum forward engine

[Olivier MATZ <olivier.matz@6wind.com>]

Hi Jijiang,

On 11/27/2014 06:03 PM, Jijiang Liu wrote:
> @@ -303,7 +305,7 @@ process_outer_cksums(void *outer_l3_hdr, uint16_t outer_ethertype,
>   * TESTPMD_TX_OFFLOAD_* in ports[tx_port].tx_ol_flags. They control
>   * wether a checksum must be calculated in software or in hardware. The
>   * IP, UDP, TCP and SCTP flags always concern the inner layer.  The
> - * VxLAN flag concerns the outer IP and UDP layer (if packet is
> + * VxLAN flag concerns the outer IP(if packet is
>   * recognized as a vxlan packet).
>   */

Please reindent the comment properly, taking care of the space before
the parenthesis.

Another comment that concerns the whole patchset. It's maybe a question
for Thomas, but I think that having patches that don't break compilation
between each other would help when bissecting.

In this case, I wonder if it's possible to split in something like:

- change PKT_TX_IPV4 and PKT_TX_IPV6 definition
- add + rename flags (update them in mbuf + testpmd + i40)
- rename inner_l{23}, l{23} in l{23}, outer_l{23} (update them in mbuf
  + testpmd + i40)

I'm not sure it's feasible, I let Thomas give his mind about this.

Regards,
Olivier