From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 33BCAA0564;
	Fri, 28 Feb 2020 13:41:44 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 08DE11BFCE;
	Fri, 28 Feb 2020 13:41:43 +0100 (CET)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 827461BFC7;
 Fri, 28 Feb 2020 13:41:41 +0100 (CET)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47])
 by mailout.nyi.internal (Postfix) with ESMTP id C6D7122196;
 Fri, 28 Feb 2020 07:41:39 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute7.internal (MEProxy); Fri, 28 Feb 2020 07:41:39 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=cWKOny3GITkb825KWyaMMaZM+V9QiRcViVkm2yvDong=; b=QWCg0x8TnpxO
 fPHZX0pvPUgkL3eTcZfdLTI0wEq07gZJP4s2wVW8tMiQQikHQc3O7sdkpMTwAGH1
 Pr9xmRfEcfq2GrLt1vSBsIiRV0bKJyT3bPSNox8ofuppYQni9wG5Ks8qbBvK2wVr
 HADCQRTZQWRtQAjr/ihWzs1URQ+C6AA=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=cWKOny3GITkb825KWyaMMaZM+V9QiRcViVkm2yvDo
 ng=; b=fYAiZbqxCizR1l9WiRQs2XcfXPOI26sUg0eDdCaiE6axaMGpel1TqW5xa
 u1VGHE+p9IBtLnmMPbDPjcSUBLKsaIsuRlwQzADFs0GMlkNfyLismP5Kp53aPBAf
 PYIPSFgVzgNufRfNRlsSqzoj4d5o5KCI0hCQw+bvgzCPqdV7Y1p0y0nlbbg94B5V
 QRLKs4JBeJOJQDZ4gREbnxHRNk03a3Wiaza4nDDqzJUQqCU5ogJBpbKiOCmLIAm/
 6i3UQw01Nc+CiKoDItTLAXHXXGQxmvz6OSbCnWvkG8EzJ1iB8gQk4C8m8lArm7r3
 6fhggYCWJAbmRC5k1Ste80IDPICTA==
X-ME-Sender: <xms:ggpZXkS70qFiRR1j-_lqn2BMmFtWNi4hVOgT9XZ1_oRVpeXMwCol6w>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrleekgdegvdcutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
 fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
 ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh
 hmrghinhepughpughkrdhorhhgnecukfhppeelfedriedrudegledruddugeenucevlhhu
 shhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmh
 honhhjrghlohhnrdhnvght
X-ME-Proxy: <xmx:ggpZXucfU-PbfOIQYf2Fvd0wdICM_PENrpMX1WtpqBFIv9qfFBtulA>
 <xmx:ggpZXlsC8K3glYhdALa4wglXVMQ_uAcCkE0vsYCajCEk0IzHlAFrnQ>
 <xmx:ggpZXiK2-GShC3tscfGlwI86njEMY39CekG0TW8xIfyz_ABSgzy90g>
 <xmx:gwpZXgDPHo_My2IeAL4tLokidA1jS0YXGZB4cs3cU0IQLyLCUCKRMA>
Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114])
 by mail.messagingengine.com (Postfix) with ESMTPA id DBA533280064;
 Fri, 28 Feb 2020 07:41:37 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Akhil Goyal <akhil.goyal@nxp.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 "roy.fan.zhang@intel.com" <roy.fan.zhang@intel.com>,
 "pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>,
 "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
 "stable@dpdk.org" <stable@dpdk.org>, Declan Doherty <declan.doherty@intel.com>,
 Luca Boccassi <bluca@debian.org>
Date: Fri, 28 Feb 2020 13:41:36 +0100
Message-ID: <5479929.MhkbZ0Pkbq@xps>
In-Reply-To: <DB8PR04MB66357F2193FEA8FE3A99B7F2E6E80@DB8PR04MB6635.eurprd04.prod.outlook.com>
References: <20200227223326.507857-1-thomas@monjalon.net>
 <DB8PR04MB66357F2193FEA8FE3A99B7F2E6E80@DB8PR04MB6635.eurprd04.prod.outlook.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] drivers/crypto: fix build with make
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

28/02/2020 13:24, Akhil Goyal:
> Hi Thomas,
> 
> > 
> > In the check for the version of intel-ipsec-mb library,
> > there is a backslash in front of the #include.
> > It is not clear why this backslash is for.
> > It is not clear why there was no error so far.
> > 
> > In an up-to-date ArchLinux, these errors were seen:
> > 
> > syntax error near unexpected token `|'
> > `grep -e "IMB_VERSION_STR" \#include <intel-ipsec-mb.h> | cut -d'"' -f2'
> > syntax error near unexpected token `|'
> > `grep -e "IMB_VERSION_NUM" \#include <intel-ipsec-mb.h> | cut -d' ' -f3'
> > 
> > The makefiles are fixed by removing the backslash.
> > 
> > Fixes: 3067c8ce77ac ("crypto/aesni_mb: fix build with custom dependency path")
> > Fixes: 457b8e372975 ("crypto/aesni_gcm: check dependency version with make")
> > Fixes: bf6eb2c22fd1 ("crypto/kasumi: use IPsec library")
> > Fixes: 7c87e2d7b359 ("crypto/snow3g: use IPsec library")
> > Fixes: 61f7c988e39e ("crypto/zuc: use IPsec library")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> 
> I see that CI is still failing after removing that backslash.

Yes my patch is failing on Intel CI:
	http://mails.dpdk.org/archives/test-report/2020-February/118888.html

I caught this issue on my machine.

> I believe the issue is not because of backslash. It is something else.

It works on my machine.

We need to find a solution which works on both environment.
Maybe the cause is using make 4.3 on my machine.