From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 5485B7EFC for ; Mon, 1 Dec 2014 10:59:59 +0100 (CET) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XvNoy-0006VY-Ij; Mon, 01 Dec 2014 11:03:10 +0100 Message-ID: <547C3C14.1040608@6wind.com> Date: Mon, 01 Dec 2014 10:59:48 +0100 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 MIME-Version: 1.0 To: Bruce Richardson References: <1417188660-14587-1-git-send-email-bruce.richardson@intel.com> <20141130010514.GA19479@localhost.localdomain> <547C3052.4080106@6wind.com> <20141201094833.GA8760@bricha3-MOBL3> In-Reply-To: <20141201094833.GA8760@bricha3-MOBL3> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix clang compile - remove truncation errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Dec 2014 09:59:59 -0000 Hi Bruce, On 12/01/2014 10:48 AM, Bruce Richardson wrote: >> I found that the following code works: >> >> tx_offload_mask.l2_len |= ~0; >> >> (note the '|=' instead of '=') >> >> I would avoid to create a macro. What do you think? >> >> Regards, >> Olivier > > Nice one - cleanest solution thus far, so I suggest we go with that option. Have > you got a patch for it ready? I'll submit the patch, after all it's my mistake! Regards, Olivier