From: Olivier MATZ <olivier.matz@6wind.com>
To: Keith Wiles <keith.wiles@windriver.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC] Clang errors with bit fields and setting value of ~0.
Date: Mon, 01 Dec 2014 11:38:09 +0100 [thread overview]
Message-ID: <547C4511.7010002@6wind.com> (raw)
In-Reply-To: <1417278816-24011-1-git-send-email-keith.wiles@windriver.com>
Hi Keith,
On 11/29/2014 05:33 PM, Keith Wiles wrote:
> error: implicit truncation from 'int' to bitfield
> changes value from -1 to 127 [-Werror,-Wbitfield-constant-conversion]
> tx_offload_mask.l2_len = ~0;
> Converted to use correct bit values
> tx_offload_mask.l2_len = 0x7f;
>
> Signer-off-by: Keith Wiles <keith.wiles@windriver.com>
> ---
> lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 28 ++++++++++++++--------------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
I just submitted a patch that fixes the same issue without having
to know the size of the bitfield.
http://dpdk.org/ml/archives/dev/2014-December/009112.html
Regards,
Olivier
prev parent reply other threads:[~2014-12-01 10:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-29 16:33 Keith Wiles
2014-12-01 10:38 ` Olivier MATZ [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547C4511.7010002@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).