From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 814AB68CD for ; Wed, 3 Dec 2014 12:41:30 +0100 (CET) Received: by mail-wg0-f41.google.com with SMTP id y19so19536177wgg.14 for ; Wed, 03 Dec 2014 03:41:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=K1Ma1bT68u7r+0Nrcs/7PQxt9re9aLauAYHVjup41AQ=; b=C+gMBkK68Hh3wkPEZ4iy1f1uhl3iVxlEyStyXOM9ZwUq0qUznjsfQjEwejOQQVQ8DY 0e0rQUD9r9G9I71YY8AKGrcs+664m8t6DWmWZpSsi/t6Wg5YiVRDzK9lA6xDrBjjycat tYWh9or2kqeguyv2SXzYz+fiWDOrYaAdkkqlkZLKCvW/SUl3nXbtwgbM1b6Df5nx4aFq K9oUxkLLi74nZxeV5C5G8f+6KPvclUm/X9fhrsQK95Ahuf7/C//mKR2SFiH8Cvxevf0I 0jSxDloIilogiGlUyIYTwuvx7VcJTaG4ROFB77d9ruOtfqIV2dkisFksL0rEkogzgbQf jaxA== X-Gm-Message-State: ALoCoQkXscJFlvi0PaG6E2u017bzA64ziM+SJLQKn8wnNh97uL1epderCcHMTkR+jXtfuNB0kDST X-Received: by 10.194.174.40 with SMTP id bp8mr6584649wjc.104.1417606890352; Wed, 03 Dec 2014 03:41:30 -0800 (PST) Received: from [10.16.0.195] (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id ck7sm20527217wjb.13.2014.12.03.03.41.29 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 03 Dec 2014 03:41:30 -0800 (PST) Message-ID: <547EF6E9.5040000@6wind.com> Date: Wed, 03 Dec 2014 12:41:29 +0100 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 MIME-Version: 1.0 To: Jijiang Liu , dev@dpdk.org References: <1417532767-1309-1-git-send-email-jijiang.liu@intel.com> <1417532767-1309-3-git-send-email-jijiang.liu@intel.com> In-Reply-To: <1417532767-1309-3-git-send-email-jijiang.liu@intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 2/3] mbuf:add three TX ol_flags and repalce PKT_TX_VXLAN_CKSUM X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Dec 2014 11:41:30 -0000 Hi Jijiang, On 12/02/2014 04:06 PM, Jijiang Liu wrote: > Replace PKT_TX_VXLAN_CKSUM with PKT_TX_UDP_TUNNEL_PKT in order to indicate a packet is an UDP tunneling packet, and introduce 3 TX offload flags for outer IP TX checksum, which are PKT_TX_OUTER_IP_CKSUM, PKT_TX_OUTER_IPV4 and PKT_TX_OUTER_IPV6 respectively;Rework csum forward engine and i40e PMD due to these changes. > > Signed-off-by: Jijiang Liu > --- > app/test-pmd/csumonly.c | 9 +++++++-- > lib/librte_mbuf/rte_mbuf.c | 7 ++++++- > lib/librte_mbuf/rte_mbuf.h | 11 ++++++++++- > lib/librte_pmd_i40e/i40e_rxtx.c | 6 +++--- > 4 files changed, 26 insertions(+), 7 deletions(-) > > diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c > index d8c080a..9094967 100644 > --- a/app/test-pmd/csumonly.c > +++ b/app/test-pmd/csumonly.c > @@ -257,7 +257,7 @@ process_outer_cksums(void *outer_l3_hdr, uint16_t outer_ethertype, > uint64_t ol_flags = 0; > > if (testpmd_ol_flags & TESTPMD_TX_OFFLOAD_VXLAN_CKSUM) > - ol_flags |= PKT_TX_VXLAN_CKSUM; > + ol_flags |= PKT_TX_UDP_TUNNEL_PKT; > > if (outer_ethertype == _htons(ETHER_TYPE_IPv4)) { > ipv4_hdr->hdr_checksum = 0; > @@ -470,7 +470,12 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) > { PKT_TX_UDP_CKSUM, PKT_TX_L4_MASK }, > { PKT_TX_TCP_CKSUM, PKT_TX_L4_MASK }, > { PKT_TX_SCTP_CKSUM, PKT_TX_L4_MASK }, > - { PKT_TX_VXLAN_CKSUM, PKT_TX_VXLAN_CKSUM }, > + { PKT_TX_UDP_TUNNEL_PKT, PKT_TX_UDP_TUNNEL_PKT }, > + { PKT_TX_IPV4, PKT_TX_IPV4 }, > + { PKT_TX_IPV6, PKT_TX_IPV6 }, > + { PKT_TX_OUTER_IP_CKSUM, PKT_TX_OUTER_IP_CKSUM }, > + { PKT_TX_OUTER_IPV4, PKT_TX_OUTER_IPV4 }, > + { PKT_TX_OUTER_IPV6, PKT_TX_OUTER_IPV6 }, > { PKT_TX_TCP_SEG, PKT_TX_TCP_SEG }, I still think having a flag IPV4 + another flag IP_CHECKSUM is not appropriate. I though Konstantin agreed on other flags, but I may have misunderstood: http://dpdk.org/ml/archives/dev/2014-November/009070.html Olivier