From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id DC8382C7A for ; Fri, 5 Dec 2014 12:11:29 +0100 (CET) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XwqqI-0000zG-9i; Fri, 05 Dec 2014 12:14:45 +0100 Message-ID: <548192D0.1040609@6wind.com> Date: Fri, 05 Dec 2014 12:11:12 +0100 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 MIME-Version: 1.0 To: Jijiang Liu , dev@dpdk.org References: <1417532767-1309-1-git-send-email-jijiang.liu@intel.com> <1417532767-1309-3-git-send-email-jijiang.liu@intel.com> In-Reply-To: <1417532767-1309-3-git-send-email-jijiang.liu@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 2/3] mbuf:add three TX ol_flags and repalce PKT_TX_VXLAN_CKSUM X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Dec 2014 11:11:30 -0000 Hi, On 12/02/2014 04:06 PM, Jijiang Liu wrote: > Replace PKT_TX_VXLAN_CKSUM with PKT_TX_UDP_TUNNEL_PKT in order to indicate a packet is an UDP tunneling packet, and introduce 3 TX offload flags for outer IP TX checksum, which are PKT_TX_OUTER_IP_CKSUM, PKT_TX_OUTER_IPV4 and PKT_TX_OUTER_IPV6 respectively;Rework csum forward engine and i40e PMD due to these changes. > > Signed-off-by: Jijiang Liu > --- > app/test-pmd/csumonly.c | 9 +++++++-- > lib/librte_mbuf/rte_mbuf.c | 7 ++++++- > lib/librte_mbuf/rte_mbuf.h | 11 ++++++++++- > lib/librte_pmd_i40e/i40e_rxtx.c | 6 +++--- > 4 files changed, 26 insertions(+), 7 deletions(-) > As we need to conclude on this: Acked-by: Olivier Matz Just few minor comments below: > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > index cbadf8e..6eb898f 100644 > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -118,7 +118,7 @@ extern "C" { > */ > #define PKT_TX_TCP_SEG (1ULL << 49) > > -#define PKT_TX_VXLAN_CKSUM (1ULL << 50) /**< TX checksum of VXLAN computed by NIC */ > +#define PKT_TX_UDP_TUNNEL_PKT (1ULL << 50) /**< TX packet is an UDP tunneling packet */ > #define PKT_TX_IEEE1588_TMST (1ULL << 51) /**< TX IEEE1588 packet to timestamp. */ We could replace the comment by: "Tell the NIC it's a UDP tunneled packet. It must be specified when using hw outer checksum offload (PKT_TX_OUTER_IP_CKSUM)" > > /** > @@ -149,6 +149,15 @@ extern "C" { > > #define PKT_TX_VLAN_PKT (1ULL << 57) /**< TX packet is a 802.1q VLAN packet. */ > > +/** Outer IP checksum of TX packet, computed by NIC for tunneling packet */ > +#define PKT_TX_OUTER_IP_CKSUM (1ULL << 58) Maybe add: "The tunnel type must also be specified, ex: PKT_TX_UDP_TUNNEL_PKT" (altought I don't understand why the hw need this info) Regards, Olivier