From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from emea01-am1-obe.outbound.protection.outlook.com (mail-am1on0053.outbound.protection.outlook.com [157.56.112.53]) by dpdk.org (Postfix) with ESMTP id 18F91282 for ; Mon, 8 Dec 2014 22:34:36 +0100 (CET) Received: from [10.6.0.187] (12.216.194.146) by DB3PR02MB011.eurprd02.prod.outlook.com (10.242.128.17) with Microsoft SMTP Server (TLS) id 15.1.26.15; Mon, 8 Dec 2014 21:31:50 +0000 Message-ID: <548618EE.2010104@ezchip.com> Date: Mon, 8 Dec 2014 13:32:30 -0800 From: Cyril Chemparathy User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Neil Horman , Zhigang Lu References: <1418029178-25162-1-git-send-email-zlu@ezchip.com> <1418029178-25162-12-git-send-email-zlu@ezchip.com> <20141208200331.GB4238@hmsreliant.think-freely.org> In-Reply-To: <20141208200331.GB4238@hmsreliant.think-freely.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [12.216.194.146] X-ClientProxiedBy: CO2PR11CA0020.namprd11.prod.outlook.com (10.141.242.158) To DB3PR02MB011.eurprd02.prod.outlook.com (10.242.128.17) X-Microsoft-Antispam: UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:DB3PR02MB011; X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(602002); SRVR:DB3PR02MB011; X-Forefront-PRVS: 041963B986 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(6049001)(199003)(377454003)(479174003)(24454002)(189002)(51704005)(20776003)(101416001)(83506001)(66066001)(120916001)(33656002)(42186005)(23746002)(68736005)(47776003)(65816999)(76176999)(4396001)(54356999)(87266999)(65956001)(86362001)(50986999)(105586002)(92566001)(87976001)(97736003)(64126003)(46102003)(106356001)(64706001)(36756003)(122386002)(107046002)(31966008)(77156002)(62966003)(99396003)(50466002)(19580395003)(80316001)(19580405001)(77096005)(59896002)(21056001)(40100003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR02MB011; H:[10.6.0.187]; FPR:; SPF:None; MLV:sfv; PTR:InfoNoRecords; A:1; MX:1; LANG:en; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:DB3PR02MB011; X-OriginatorOrg: ezchip.com X-Mailman-Approved-At: Mon, 08 Dec 2014 22:54:58 +0100 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 11/15] eal/tile: add EAL support for global mPIPE initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Dec 2014 21:34:36 -0000 Hi Neil, On 12/8/2014 12:03 PM, Neil Horman wrote: > On Mon, Dec 08, 2014 at 04:59:34PM +0800, Zhigang Lu wrote: >> The TileGx mPIPE hardware provides Ethernet connectivity, >> packet classification, and packet load balancing services. >> >> Signed-off-by: Zhigang Lu >> Signed-off-by: Cyril Chemparathy >> --- >> .../common/include/arch/tile/rte_mpipe.h | 67 ++++++++++ >> lib/librte_eal/linuxapp/eal/Makefile | 3 + >> lib/librte_eal/linuxapp/eal/eal.c | 9 ++ >> lib/librte_eal/linuxapp/eal/eal_mpipe_tile.c | 147 +++++++++++++++++++++ >> mk/rte.app.mk | 4 + >> 5 files changed, 230 insertions(+) >> create mode 100644 lib/librte_eal/common/include/arch/tile/rte_mpipe.h >> create mode 100644 lib/librte_eal/linuxapp/eal/eal_mpipe_tile.c >> > This seems like the wrong way to implement mpip access. If you want to use it > for networking access, you should create a pmd to talk to it. If you just want > raw gxio access, you already have a gxio library that applications can interface > to. Theres no need to create addtional DPDK api services just to wrap it up, > especially given that those surfaces won't exist outside of the tile arch (i.e. > this allows for the creation of very non-portable applications). Thanks for the taking a look. The mPIPE hardware block includes hardware managed buffer pools, which we've abstracted under the mempool interface in the very next patch in the series. As a result of this mempool dependency, mPIPE needs to be globally initialized on TileGX architecture. The alternative is to not include support for the hardware managed buffer pool, but that decision incurs a significant performance hit. Thanks -- Cyril.