From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id DF97169D4; Wed, 20 Mar 2019 14:55:41 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 15DE8B40068; Wed, 20 Mar 2019 13:55:40 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 20 Mar 2019 13:55:33 +0000 To: David Marchand , CC: , , , , References: <1552318522-18777-1-git-send-email-david.marchand@redhat.com> <1553076154-3907-1-git-send-email-david.marchand@redhat.com> <1553076154-3907-3-git-send-email-david.marchand@redhat.com> From: Andrew Rybchenko Message-ID: <5487fdb1-0a4d-3a8f-7092-742c1c49a5d5@solarflare.com> Date: Wed, 20 Mar 2019 16:55:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <1553076154-3907-3-git-send-email-david.marchand@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24500.003 X-TM-AS-Result: No-0.605300-8.000000-10 X-TMASE-MatchedRID: wQVy7q402w12LasmHuCXMSa1MaKuob8PC/ExpXrHizy8kZ65nVll7NtG XN18RN7jiLNQUOYyZS5shy45quVtAUhqp1+PG3TKkmtbTcNpxYQpY+dgnkDLajhgoAzehG32dYn RLHmvjkDi8zVgXoAltkWL4rBlm20vZiFQvkZhFu1q8/xv2Um1avoLR4+zsDTtHtexZ1+/9PnBpz 169ZZ+FGgqDZBvUQ5B3YhEV4ThpyTswIgvJS0Pjf4h4qcnkp1QZjVu7lQ/P2y81TO4b2FFseaH7 GliG3GYp2BgLFGBb/NR029mOM6P0LrcE8xytxC5d5hZXZFoB8PxWx93BSYyycC+ksT6a9fy X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--0.605300-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24500.003 X-MDID: 1553090140-IEHO7D3jj-l1 Subject: Re: [dpdk-dev] [PATCH v3 2/4] app/testpmd: extend fwd statistics to 64bits X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Mar 2019 13:55:42 -0000 On 3/20/19 1:02 PM, David Marchand wrote: > fwd engine statistics are stored as unsigned int (32bits) and can wrap > quite quickly. > Example: sending 7mpps for 614s gives us 4298000000 packets => > 0x1002e4680 larger than 32bits. > > testpmd reports forwarding stats as: > RX-packets: 3500381 TX-packets: 3500010 TX-dropped: 371 > > While the port and accumulated stats are reported as 64bits: > RX-packets: 4298467677 RX-dropped: 0 RX-total: 4298467677 > TX-packets: 4298467306 TX-dropped: 371 TX-total: 4298467677 > > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand Reviewed-by: Andrew Rybchenko RX and Rx are used for error stats. Don't know why. But the patch simply preserves it, so not a problem of the patch. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B5E72A00E6 for ; Wed, 20 Mar 2019 14:55:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BADBD7D05; Wed, 20 Mar 2019 14:55:43 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id DF97169D4; Wed, 20 Mar 2019 14:55:41 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 15DE8B40068; Wed, 20 Mar 2019 13:55:40 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 20 Mar 2019 13:55:33 +0000 To: David Marchand , CC: , , , , References: <1552318522-18777-1-git-send-email-david.marchand@redhat.com> <1553076154-3907-1-git-send-email-david.marchand@redhat.com> <1553076154-3907-3-git-send-email-david.marchand@redhat.com> From: Andrew Rybchenko Message-ID: <5487fdb1-0a4d-3a8f-7092-742c1c49a5d5@solarflare.com> Date: Wed, 20 Mar 2019 16:55:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <1553076154-3907-3-git-send-email-david.marchand@redhat.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24500.003 X-TM-AS-Result: No-0.605300-8.000000-10 X-TMASE-MatchedRID: wQVy7q402w12LasmHuCXMSa1MaKuob8PC/ExpXrHizy8kZ65nVll7NtG XN18RN7jiLNQUOYyZS5shy45quVtAUhqp1+PG3TKkmtbTcNpxYQpY+dgnkDLajhgoAzehG32dYn RLHmvjkDi8zVgXoAltkWL4rBlm20vZiFQvkZhFu1q8/xv2Um1avoLR4+zsDTtHtexZ1+/9PnBpz 169ZZ+FGgqDZBvUQ5B3YhEV4ThpyTswIgvJS0Pjf4h4qcnkp1QZjVu7lQ/P2y81TO4b2FFseaH7 GliG3GYp2BgLFGBb/NR029mOM6P0LrcE8xytxC5d5hZXZFoB8PxWx93BSYyycC+ksT6a9fy X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--0.605300-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24500.003 X-MDID: 1553090140-IEHO7D3jj-l1 Subject: Re: [dpdk-dev] [PATCH v3 2/4] app/testpmd: extend fwd statistics to 64bits X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190320135530.g3NAbtyJ2GhPXdqcZup3XDDKSTPvodZRS2MFoJARi9w@z> On 3/20/19 1:02 PM, David Marchand wrote: > fwd engine statistics are stored as unsigned int (32bits) and can wrap > quite quickly. > Example: sending 7mpps for 614s gives us 4298000000 packets => > 0x1002e4680 larger than 32bits. > > testpmd reports forwarding stats as: > RX-packets: 3500381 TX-packets: 3500010 TX-dropped: 371 > > While the port and accumulated stats are reported as 64bits: > RX-packets: 4298467677 RX-dropped: 0 RX-total: 4298467677 > TX-packets: 4298467306 TX-dropped: 371 TX-total: 4298467677 > > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand Reviewed-by: Andrew Rybchenko RX and Rx are used for error stats. Don't know why. But the patch simply preserves it, so not a problem of the patch.