From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 425DA1B4AD for ; Thu, 27 Sep 2018 14:48:42 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0AF6721C76; Thu, 27 Sep 2018 08:48:41 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 27 Sep 2018 08:48:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=TLm0Tr7kyj++S+TJdKTse2dfnq 40EESBf/oNiHwgRyA=; b=gom6zQTfa4+BNPCadjmUefTfVAaxHnF39rCgQQHh3d +6sWtI6Kxf5txD6roWrUJBiQtSTue8ZHzKHJSZjnlYQWdJebDA5blQ8KFppiLsZW oEgL3wgUTasFOQVj2iwHQcNDvFRSO6rRrB27UW/RcfAddjygjlifjP42yd+Dg/K0 Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=TLm0Tr 7kyj++S+TJdKTse2dfnq40EESBf/oNiHwgRyA=; b=p1vUWvP3+9WIUOJb3ng4pO ABr86kCNTzhaWxtiD3wpXzsPwl9O+To1YjjuwVfibLNkBkH8hm7PKzfiu0kfer3u ssIc3CKgYSUlf8bsPeoiMntTa2ra7WJOKHwJjMc7enKp8/u2ddlIu+S3TJfglssb rbVl9Muq4USH5Ga6Eglk7mFMgxa2j1QPLw8SFaDhVLQVDP8Bl1sAF8uJuHMShRwg MlVLwWQ+EvirTrH/NqcMaWzguOHIZ4Bn/Uegpe9QiyYPBX3/WxS8kc3z4uoi6fvY kc2QxLIEmKDJnE4Dcyg4AUDP+DitdUDvQ4Xo6s0P7s7NHk4+tO9BiS/2xY8+502A == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B7084102A0; Thu, 27 Sep 2018 08:48:39 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: Raslan Darawsheh , dev@dpdk.org, shahafs@mellanox.com, orika@mellanox.com Date: Thu, 27 Sep 2018 14:48:38 +0200 Message-ID: <5489324.HoVYYzflKP@xps> In-Reply-To: <20180927123053.GB776@bricha3-MOBL.ger.corp.intel.com> References: <1538047613-27309-1-git-send-email-rasland@mellanox.com> <9568922.17cOiG4SW6@xps> <20180927123053.GB776@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] examples/client_server_mp: add sigint handler to server X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Sep 2018 12:48:42 -0000 27/09/2018 14:30, Bruce Richardson: > On Thu, Sep 27, 2018 at 01:36:06PM +0200, Thomas Monjalon wrote: > > 27/09/2018 13:26, Raslan Darawsheh: > > > v2: > > > - fix includes order > > > > I'm afraid you will need a v3 to fix spacing :) > > > > > --- a/examples/multi_process/client_server_mp/mp_server/main.c > > > +++ b/examples/multi_process/client_server_mp/mp_server/main.c > > > @@ -37,6 +37,7 @@ > > > #include "common.h" > > > #include "args.h" > > > #include "init.h" > > > +#include > > > > A space is missing here. > > > > Also, the norm in DPDK is to list all standard headers first, then the DPDK > headers and finally the local headers. "signal.h" therefore should be > further up in the file, with the first group. I think he did that already in v3 :)