From: Tetsuya Mukawa <mukawa@igel.co.jp>
To: Huawei Xie <huawei.xie@intel.com>, dev@dpdk.org
Cc: haifeng.lin@intel.com
Subject: Re: [dpdk-dev] [PATCH RFC v2 00/12] lib/librte_vhost: vhost-user support
Date: Mon, 15 Dec 2014 14:26:14 +0900 [thread overview]
Message-ID: <548E70F6.30807@igel.co.jp> (raw)
In-Reply-To: <1418247477-13920-1-git-send-email-huawei.xie@intel.com>
Hi Xie,
I've got warnings from checkpatch.pl.
Mostly 'over 80 characters' warnings.
(But I know these are come from original vhost-example code sometimes.)
So far, your patches are RFC, so I haven't check these strictly.
Thanks,
Tetsuya
(2014/12/11 6:37), Huawei Xie wrote:
> This patchset refines vhost library to support both vhost-cuse and vhost-user.
>
>
> Huawei Xie (12):
> create vhost_cuse directory and move vhost-net-cdev.c to vhost_cuse directory
> rename vhost-net-cdev.h as vhost-net.h
> move eventfd_copy logic out from virtio-net.c to vhost-net-cdev.c
> exact copy of host_memory_map from virtio-net.c to new file
> virtio-net-cdev.c
> host_memory_map refine: map partial memory of target process into current process
> cuse_set_memory_table is the VHOST_SET_MEMORY_TABLE message handler for cuse
> fd management for vhost user
> vhost-user support
> minor fix
> vhost-user memory region map/unmap
> kick/callfd fix
> cleanup when vhost user connection is closed
>
> lib/librte_vhost/Makefile | 5 +-
> lib/librte_vhost/rte_virtio_net.h | 2 +
> lib/librte_vhost/vhost-net-cdev.c | 389 ----------------------
> lib/librte_vhost/vhost-net-cdev.h | 113 -------
> lib/librte_vhost/vhost-net.h | 117 +++++++
> lib/librte_vhost/vhost_cuse/vhost-net-cdev.c | 452 ++++++++++++++++++++++++++
> lib/librte_vhost/vhost_cuse/virtio-net-cdev.c | 349 ++++++++++++++++++++
> lib/librte_vhost/vhost_cuse/virtio-net-cdev.h | 45 +++
> lib/librte_vhost/vhost_rxtx.c | 2 +-
> lib/librte_vhost/vhost_user/fd_man.c | 205 ++++++++++++
> lib/librte_vhost/vhost_user/fd_man.h | 64 ++++
> lib/librte_vhost/vhost_user/vhost-net-user.c | 423 ++++++++++++++++++++++++
> lib/librte_vhost/vhost_user/vhost-net-user.h | 107 ++++++
> lib/librte_vhost/vhost_user/virtio-net-user.c | 313 ++++++++++++++++++
> lib/librte_vhost/vhost_user/virtio-net-user.h | 49 +++
> lib/librte_vhost/virtio-net.c | 394 ++--------------------
> lib/librte_vhost/virtio-net.h | 43 +++
> 17 files changed, 2199 insertions(+), 873 deletions(-)
> delete mode 100644 lib/librte_vhost/vhost-net-cdev.c
> delete mode 100644 lib/librte_vhost/vhost-net-cdev.h
> create mode 100644 lib/librte_vhost/vhost-net.h
> create mode 100644 lib/librte_vhost/vhost_cuse/vhost-net-cdev.c
> create mode 100644 lib/librte_vhost/vhost_cuse/virtio-net-cdev.c
> create mode 100644 lib/librte_vhost/vhost_cuse/virtio-net-cdev.h
> create mode 100644 lib/librte_vhost/vhost_user/fd_man.c
> create mode 100644 lib/librte_vhost/vhost_user/fd_man.h
> create mode 100644 lib/librte_vhost/vhost_user/vhost-net-user.c
> create mode 100644 lib/librte_vhost/vhost_user/vhost-net-user.h
> create mode 100644 lib/librte_vhost/vhost_user/virtio-net-user.c
> create mode 100644 lib/librte_vhost/vhost_user/virtio-net-user.h
> create mode 100644 lib/librte_vhost/virtio-net.h
>
next prev parent reply other threads:[~2014-12-15 5:26 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 21:37 Huawei Xie
2014-12-10 21:37 ` [dpdk-dev] [PATCH RFC v2 01/12] lib/librte_vhost: mov vhost-cuse implementation to vhost_cuse directory Huawei Xie
2014-12-10 21:37 ` [dpdk-dev] [PATCH RFC v2 02/12] lib/librte_vhost: rename vhost-net-cdev.h as vhost-net.h Huawei Xie
2014-12-10 21:37 ` [dpdk-dev] [PATCH RFC v2 03/12] lib/librte_vhost: move event_copy logic from virtio-net.c to vhost-net-cdev.c Huawei Xie
2015-01-07 9:10 ` Xie, Huawei
2014-12-10 21:37 ` [dpdk-dev] [PATCH RFC v2 04/12] lib/librte_vhost: copy of host_memory_map from virtio-net.c to new file virtio-net-cdev.c Huawei Xie
2014-12-10 21:37 ` [dpdk-dev] [PATCH RFC v2 05/12] lib/librte_vhost: host_memory_map refine Huawei Xie
2014-12-10 21:37 ` [dpdk-dev] [PATCH RFC v2 06/12] lib/librte_vhost: cuse_set_memory_table Huawei Xie
2014-12-15 5:20 ` Tetsuya Mukawa
2014-12-10 21:37 ` [dpdk-dev] [PATCH RFC v2 07/12] lib/librte_vhost: async event and callback Huawei Xie
2014-12-15 5:20 ` Tetsuya Mukawa
2014-12-17 17:51 ` Xie, Huawei
2014-12-10 21:37 ` [dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user support Huawei Xie
2014-12-11 5:36 ` Linhaifeng
2015-01-05 10:21 ` Xie, Huawei
2015-01-23 3:40 ` Xie, Huawei
2015-01-23 3:53 ` Linhaifeng
2014-12-11 6:04 ` Linhaifeng
2014-12-11 17:13 ` Xie, Huawei
2014-12-12 2:25 ` Linhaifeng
2014-12-11 20:16 ` Xie, Huawei
2015-01-23 3:36 ` Xie, Huawei
2015-01-23 8:36 ` Linhaifeng
2014-12-16 3:05 ` Tetsuya Mukawa
2014-12-17 1:06 ` Xie, Huawei
2014-12-17 3:31 ` Tetsuya Mukawa
2014-12-17 4:22 ` Tetsuya Mukawa
2014-12-17 17:31 ` Xie, Huawei
2014-12-19 3:36 ` Tetsuya Mukawa
2014-12-24 7:21 ` Tetsuya Mukawa
2015-01-04 9:53 ` Xie, Huawei
2014-12-10 21:37 ` [dpdk-dev] [PATCH RFC v2 09/12] lib/librte_vhost: minor fix Huawei Xie
2014-12-10 21:37 ` [dpdk-dev] [PATCH RFC v2 10/12] lib/librte_vhost: vhost-user memory region map Huawei Xie
2014-12-16 2:38 ` Tetsuya Mukawa
2014-12-10 21:37 ` [dpdk-dev] [PATCH RFC v2 11/12] lib/librte_vhost: kick/callfd fix Huawei Xie
2014-12-10 21:37 ` [dpdk-dev] [PATCH RFC v2 12/12] lib/librte_vhost: cleanup when vhost user socket connection is closed Huawei Xie
2014-12-10 22:04 ` [dpdk-dev] [PATCH RFC v2 00/12] lib/librte_vhost: vhost-user support Xie, Huawei
2014-12-11 2:21 ` Tetsuya Mukawa
2014-12-15 5:26 ` Tetsuya Mukawa [this message]
2014-12-17 17:43 ` Xie, Huawei
2015-01-07 12:43 ` Qiu, Michael
2015-01-23 8:16 ` Linhaifeng
2015-01-26 7:24 ` Xie, Huawei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548E70F6.30807@igel.co.jp \
--to=mukawa@igel.co.jp \
--cc=dev@dpdk.org \
--cc=haifeng.lin@intel.com \
--cc=huawei.xie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).