From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 0160568BF for ; Thu, 18 Dec 2014 14:06:09 +0100 (CET) Received: by mail-wi0-f182.google.com with SMTP id h11so1730334wiw.9 for ; Thu, 18 Dec 2014 05:06:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type; bh=vY+YMUKyaVQIzVjAZNfL8ojWmhxeRiAf5m+xzqbWbr0=; b=bM0BFRGsMWcc61RjM+mpTwU40Yg5EJL7SFFnHfZV1myPJIKgo0ETZFr3YmmTfQQEsw RB9yYbIKI2GyRNDEJH8HIdDMX5fA2bNYEW+i2e1iFDg3UU8YC/03WJJhVpI12yzvJCyf XjO1ILqKTPgXbA75dMquBntfvFCuDGDJLIguEj2bKgOZEkb6hVgRW0udk5Oowk6B27Ip b2USETStswe+iSL/kQHxQtq1LOS/iXNWwOnpwlTDdqZzB2ABwhPewMLBjQfspOaoV563 mb4g8nC7hmwdp2mkdkGf6FxqmE5BxDS0bcIIwJF23TEkJXmIswQ8bN90s83f9Fy/Qb84 LKvA== X-Gm-Message-State: ALoCoQnHEQivcOJsSHObzIbY13vibSoQBykOPiSdDFFwDmr+y2eRI9CGNEIpwqZvYt1P4V3bsvgB X-Received: by 10.180.84.98 with SMTP id x2mr5013324wiy.14.1418907968301; Thu, 18 Dec 2014 05:06:08 -0800 (PST) Received: from [10.0.0.165] (system.cloudius-systems.com. [84.94.198.183]) by mx.google.com with ESMTPSA id ex8sm8874993wjd.41.2014.12.18.05.06.06 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Dec 2014 05:06:07 -0800 (PST) Message-ID: <5492D13C.4020006@cloudius-systems.com> Date: Thu, 18 Dec 2014 15:06:04 +0200 From: Vlad Zolotarov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: "dev@dpdk.org" , "Ouyang, Changchun" References: <1418897516-25918-1-git-send-email-vladz@cloudius-systems.com> In-Reply-To: <1418897516-25918-1-git-send-email-vladz@cloudius-systems.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 0/6] Enable VF RSS for Niantic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Dec 2014 13:06:10 -0000 On 12/18/14 12:11, Vlad Zolotarov wrote: > From: Changchun Ouyang > > This patch enables VF RSS for Niantic, which allow each VF having at most 4 queues. > The actual queue number per VF depends on the number of VF: > VF number from 1~32: 4 queues per VF; > VF number from 33~max vf num: 2 queues per VF; > > On host, to enable VF RSS functionality, mq mode should be set as ETH_MQ_RX_VMDQ_RSS > or ETH_MQ_RX_RSS mode, and SRIOV mode should be activated. > It also needs config VF RSS information like hash function, RSS key, RSS key length. This patch series is missing a few things: 1. Taking into the consideration the number of Rx queues requested by a user in the rte_eth_dev_configure(). 2. dev->dev_ops->reta_query used by a rte_eth_dev_rss_reta_query() is still not initialized for a VF. Thus there is no way to query the RSS table contents. 3. rte_eth_dev_info_get() returns reta_size == 0 when called for a VF function. thanks, vlad > > Changchun Ouyang (6): > ixgbe: Code cleanup > ixgbe: Negotiate VF API version > ixgbe: Get VF queue number > ether: Check VMDq RSS mode > ixgbe: Config VF RSS > testpmd: Set Rx VMDq RSS mode > > app/test-pmd/testpmd.c | 9 ++++ > lib/librte_ether/rte_ethdev.c | 21 ++++++-- > lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 1 + > lib/librte_pmd_ixgbe/ixgbe_pf.c | 75 ++++++++++++++++++++++++++++- > lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 95 +++++++++++++++++++++++++++---------- > 5 files changed, 171 insertions(+), 30 deletions(-) > > --