From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 5055C44C7 for ; Sun, 14 Jan 2018 23:43:05 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D2D35208A4; Sun, 14 Jan 2018 17:43:04 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Sun, 14 Jan 2018 17:43:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=Ly1jR1xpZuMRvkazANvxpYTk38 4JRXWiLJZiSiO7uhA=; b=TUPcwE3Dl1wFArxZG10oWn63s+elGolkxKaF+XRzpF Loh8Wr3xFENry7NsuzVD+vaCw9Jz9qaVYQ6RcZfk9klgdWuF8QUOzyIFAuyD+FoQ 7EJ7F7oF5Z/71HHaqnsY8qZcSm0KzksdKOG1ZF7HTV68h3+Qc+QeiwVjWG/qrb3X E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Ly1jR1 xpZuMRvkazANvxpYTk384JRXWiLJZiSiO7uhA=; b=JTjO9UT7zcHpVHSp8rW4bq gjKPkAKf/CaGgEO0pL9SQLN/zdmRb4deYi/Sv3f2IZsxYrXqJbpBbkG2auU870BH BEWTYX+6+U5TU9Aun8Qr20nD2YclfBxuvM4ii0aC7ha8n+cy+VLlP+7Wh/oCTDos evjjCVMyivLcJtchkf+qlcZAAxjoHXdcIio/3jmY+N1XuR0v8MtxnGROjccXY6QV etOUuoxWA2Wqni34yJeU8O2PcjIRwblbKQaOdhCS6jr2z/iiiTHp06eILl7QFego TugVW8003ovlJMicFVz9fAgGiK8l9H+HTUPdlneHvK3g2NlsTE6agcYKnYEWvP7w == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 843287E2C9; Sun, 14 Jan 2018 17:43:04 -0500 (EST) From: Thomas Monjalon To: Shreyansh Jain Cc: dev@dpdk.org, hemant.agrawal@nxp.com, fiona.trahe@intel.com, rosen.xu@intel.com Date: Sun, 14 Jan 2018 23:42:32 +0100 Message-ID: <5499617.M9cdW8ba0B@xps> In-Reply-To: <20180102125749.2379-2-shreyansh.jain@nxp.com> References: <20180102125749.2379-1-shreyansh.jain@nxp.com> <20180102125749.2379-2-shreyansh.jain@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1 1/5] rawdev: introduce raw device library support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Jan 2018 22:43:05 -0000 Hi, 02/01/2018 13:57, Shreyansh Jain: > A device is DPDK has a flavor to it - ethernet, crypto, event etc. I don't understand this sentence. I guess it can be completely removed. > A rawdevice represents a generic device map-able to a device flavour > not being currently handled out-of-the-box by DPDK framework. > A device which can be scanned on an installed bus (pci, fslmc, ...) > or instantiated through devargs, can be interfaced using > standardized APIs just like other standardized devices. > > This library introduces an API set which can be plugged on the > northbound side to the application layer, and on the southbound side > to the driver layer. > > The APIs of rawdev library exposes some generic operations which can > enable configuration and I/O with the raw devices. You should explain that it uses some opaque pointers. > Signed-off-by: Shreyansh Jain > --- > lib/librte_rawdev/Makefile | 27 ++ > lib/librte_rawdev/rte_rawdev.c | 540 ++++++++++++++++++++++++++++ > lib/librte_rawdev/rte_rawdev.h | 586 ++++++++++++++++++++++++++++++ > lib/librte_rawdev/rte_rawdev_pmd.h | 588 +++++++++++++++++++++++++++++++ > lib/librte_rawdev/rte_rawdev_version.map | 33 ++ Please add an entry in MAINTAINERS with EXPERIMENTAL tag. Sorry, no time to review the code myself. Thanks