From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 09F692A9 for ; Mon, 29 Dec 2014 09:47:25 +0100 (CET) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Y5W2B-00079p-H0; Mon, 29 Dec 2014 09:50:52 +0100 Message-ID: <54A11509.5050904@6wind.com> Date: Mon, 29 Dec 2014 09:47:05 +0100 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0 MIME-Version: 1.0 To: Ravi Kerur , dev@dpdk.org References: <1419521597-31978-1-git-send-email-rkerur@gmail.com> In-Reply-To: <1419521597-31978-1-git-send-email-rkerur@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 0/7] Move EAL common functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Dec 2014 08:47:25 -0000 Hi Ravi, On 12/25/2014 04:33 PM, Ravi Kerur wrote: > Common functions in linuxapp and bsdapp are moved into > librte_eal/common directory. > New files added follow _common_ naming conventions. > Tested against ubuntu and FreeBSD. Trying to factorize the common code goes in the good direction. However I'm wondering if "common" is the proper place. Initially, the common directory was for code common to linuxapp and baremetal. Now that baremetal does not exist anymore, a lot of code is common to the 2 OSes that are supported (linux and FreeBSD). What about moving this code in "common-posix" instead? It would let the door open for future ports (Windows? or any other real time OS? Or back in baremetal?). Regards, Olivier