From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 009865A03 for ; Mon, 29 Dec 2014 14:16:36 +0100 (CET) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Y5aEf-0007Fk-Rl; Mon, 29 Dec 2014 14:20:03 +0100 Message-ID: <54A15420.2010401@6wind.com> Date: Mon, 29 Dec 2014 14:16:16 +0100 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0 MIME-Version: 1.0 To: Neil Horman References: <1419521597-31978-1-git-send-email-rkerur@gmail.com> <54A11509.5050904@6wind.com> <20141229124723.GA27775@localhost.localdomain> In-Reply-To: <20141229124723.GA27775@localhost.localdomain> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/7] Move EAL common functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Dec 2014 13:16:37 -0000 Hi Neil, On 12/29/2014 01:47 PM, Neil Horman wrote: > On Mon, Dec 29, 2014 at 09:47:05AM +0100, Olivier MATZ wrote: >> Trying to factorize the common code goes in the good direction. >> >> However I'm wondering if "common" is the proper place. Initially, >> the common directory was for code common to linuxapp and baremetal. >> Now that baremetal does not exist anymore, a lot of code is common >> to the 2 OSes that are supported (linux and FreeBSD). >> >> What about moving this code in "common-posix" instead? >> It would let the door open for future ports (Windows? or any >> other real time OS? Or back in baremetal?). >> > Posix doesn't make sense IMO, in that a large segment of the functions embodied > in the common directory have nothing to do with posix API's, and are simply just > useful functions that have not OS specific dependency (the entire > eal_common_memory.c file for example, to name just one). > > If you wanted to rename the directory, I would say generic-os would be more > appropriate. That's probably right for most of the code in the patch. I just wanted to point out that "common" is sometimes a bit vague (common to archs, common to OSes, common to all). >>From a quick look, these 2 files could be concerned and could go to a common-posix directory: - eal.c (use fopen/ftruncate/fcntl/mmap/...) - eal_thread.c (use pipe/read/write) There's no urgency to do that now and maybe we should wait it's really needed. I was just seizing the opportunity as the code is moved. Regards, Olivier